Skip to content

Conversation

@Dzejkop
Copy link
Contributor

@Dzejkop Dzejkop commented Dec 16, 2025

Description

Adds support for providing a JWT secret to auth against the provided RPC url.

Also fixes an inverted if statement

Testing

Tested manually

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Dec 16, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

var genesis *core.Genesis
var err error
if chainID != "" {
chainIDBig, ok := new(big.Int).SetString(chainID, 10)
Copy link
Contributor Author

@Dzejkop Dzejkop Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original logic here was inverted. This line

			chainIDBig, ok := new(big.Int).SetString(chainID, 10)

would be executed if chainId was equal to empty string. Hence this drive-by fix

@cb-heimdall
Copy link
Collaborator

Review Error for meyer9 @ 2026-01-02 17:55:58 UTC
User failed mfa authentication, see go/mfa-help

@meyer9 meyer9 enabled auto-merge (squash) January 4, 2026 18:52
@meyer9 meyer9 merged commit 2eedfee into base:main Jan 4, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants