fix(DB/Quests): Fix multiple quest requirements in Kolramas hub

[rorshan]

There were multiple quests in the Kolramas Argent Crusade with incorrect quest requirements.

Changes Proposed:

This PR proposes changes to:

• Core (units, players, creatures, game systems).
• Scripts (bosses, spell scripts, creature scripts).
• Database (SAI, creatures, etc).

Issues Addressed:

• Closes Various incorrect quest requirements at Kolramas Argent Crusade Camp #24044
• Closes [Quest][Zul'Drak] Pa'Troll chromiecraft/chromiecraft#8580
• Closes Death to the Necromagi quest has incorrect requirements #24041
• Closes [Missing Quest][Zul'Drak] Death to the Necromagi not available chromiecraft/chromiecraft#8596

SOURCE:

The changes have been validated through:

• Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
• Sniffs (remember to share them with the open source community!)
• Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
• The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

• Tested in-game by the author.
• Tested in-game by other community members/someone else other than the author/has been live on production servers.
• This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

• This pull request can be tested by following the reproduction steps provided in the linked issue
• This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

1. .go quest starter 12598
2. The only quest available in this hub should be Leave No One Behind from Dr. Rogers
3. Add Pa'Troll .quest add 12596
4. Throwing Down should now be available from Captain Rupert
5. Complete Throwing Down .quest add 12598, .quest complete 12598, .quest reward 12598
6. Cocooned!, Death to the Necromagi, and Skimmer Spinnerets should now be available from Captain Rupert, Sergeant Moonshard and Specialist Cogwheel respectively.

The 2 next sections can be tested in either order.

Part 1

1. Complete Death to the Necromagi .quest add 12552, .quest complete 12552, .quest reward 12552
2. Pure Evil should now be available from Captain Rupert.

Part 2

1. Complete Skimmer Spinnerets: .quest add 12553, .quest complete 12553, .quest reward 12553
2. Crashed Sprayer should now be available from Specialist Cogwheel
3. Complete Crashed Sprayer: .quest add 12583, .quest complete 12583, .quest reward 12583
4. A Tangled Skein should now be available from Specialist Cogwheel.

Known Issues and TODO List:

Characters who completed or have in their quest log A Tangled Skein before completing Throwing Down can not be offered Throwing Down. The fixes in this PR do not solve this issue for characters already affected, but it prevents future occurrences.

Server owners can attempt to fix this issue for affected characters by removing A Tangled Skein and the 2 previous quests (Crashed Sprayer and Skimmer Spinnerets) from both quest completion and quest logs:

The following is to be run on the character database.

-- Find completion of the 3 invalid quests which can result in A Tangled Skein completion
SELECT `c`.*
FROM `character_queststatus_rewarded` AS `c`
LEFT JOIN (
    SELECT `Guid`
    FROM `character_queststatus_rewarded`
    WHERE `Quest` = 12598
) AS `x` ON `x`.`Guid` = `c`.`Guid`
WHERE `c`.`Quest` IN (12553, 12583, 12555)
  AND `x`.`Guid` IS NULL;

-- Remove completion of the 3 invalid quests which can result in A Tangled Skein completion
DELETE `c`
FROM `character_queststatus_rewarded` AS `c`
LEFT JOIN (
    SELECT `Guid`
    FROM `character_queststatus_rewarded`
    WHERE `Quest` = 12598
) AS `x` ON `x`.`Guid` = `c`.`Guid`
WHERE `c`.`Quest` IN (12553, 12583, 12555)
  AND `x`.`Guid` IS NULL;

-- Find in quest logs the 3 invalid quests which can result in A Tangled Skein completion
SELECT *
FROM `character_queststatus` AS `qstatus`
WHERE `qstatus`.`Quest` IN (12553, 12583, 12555)
  AND NOT EXISTS (
        SELECT 1
        FROM `character_queststatus_rewarded` AS `qreward`
        WHERE `qstatus`.`Guid` = `qreward`.`Guid`
          AND `qreward`.`Quest` = 12598
  );

-- Remove from quest logs the 3 invalid quests which can result in A Tangled Skein completion
DELETE `qstatus`
FROM `character_queststatus` AS `qstatus`
WHERE `qstatus`.`Quest` IN (12553, 12583, 12555)
  AND NOT EXISTS (
        SELECT 1
        FROM `character_queststatus_rewarded` AS `qreward`
        WHERE `qstatus`.`Guid` = `qreward`.`Guid`
          AND `qreward`.`Quest` = 12598
  );

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

[TheSCREWEDSoftware]

I've tested this yesterday while helping Rorshan with the SQL,

[TheSCREWEDSoftware]

when running the query.

/* SQL Error (1064): You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'DELETE qstatus
FROM acore_characters.character_queststatus qstatus
WHERE qstat' at line 13 */

Even if it's optional SQL for the people to run do not use database names in, just tell where to run (this case characters) and give the query with table names and no database defined.

Don't
acore_characters.character_queststatus_rewarded
just do character_queststatus_rewarded while running it on acore_characters

[rorshan]

when running the query.

/* SQL Error (1064): You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'DELETE qstatus
FROM acore_characters.character_queststatus qstatus
WHERE qstat' at line 13 */

Edited to fix this error and to properly fit SQL style standards