fix: parse data uris according to rfc 2397 #7295
Open
+86
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhassan1
force-pushed
the
data-uri-rfc-2397
branch
3 times, most recently
from
5b8e04c to
0aac668
Compare
mhassan1
force-pushed
the
data-uri-rfc-2397
branch
from
0aac668 to
a37e799
Compare
mhassan1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the non-compliant
DATA_URL_PATTERNregular expression infromDataURIwith thedata-uri-to-bufferlibrary, which is compliant with RFC 2397.Before this change, the following valid Data URIs resulted in
Invalid URL:data:;base64,MTIzdata:application/octet-stream,123data:text/plain;charset=US-ASCII,123It uses
data-uri-to-buffer@3, which supports Node.js 6+.