-
-
Notifications
You must be signed in to change notification settings - Fork 442
Build multiple JDKs and junit test reports #715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@authorjapps Done. When reviewing the workflow I have detected some points where it can be improved. Please, let me know if you want to add any of them:
|
@javiertuya , All sounds great updates and make the build process would be much more meaningful. Happy to review when ready! |
@authorjapps Done. There is a small improvement in the overall time (times seem to be below 10s), mainly due to the container spin-up, and the test step log size is 8K lines shorter. |
|
Approved 🟢 @javiertuya , you can merge anytime you get chance. |
@authorjapps I can't merge because the merge button is disabled. The cause (I guess) is the branch protection rule configuration for master: Currently, in the "Require status checks to pass before merging" there is a single requirement for the "build" status check. But now, the build status does not exist, there is a status check for each of the Java version: build (8), build (11) ... Could you please check Settings -> Branches -> (edit the master branch protection rule) -> Require status checks to pass before merging? Remove build and add build (8), build (11), build (17), build (21), build (23), |
|
yeah, just seen it @javiertuya , but not sure which rule is blocking it, it's disable for me as well. I have given a rerun, just to rule out a fresh run.
|
Fixed. @javiertuya , Can you check if the "merge PR" Green 🟢 button is enabled for you ? |
@authorjapps Yes, it is fine. Merging now |

Fixed Which Issue?
PR Branch
javiertuya:714-multiple-jdks
Motivation and Context
After merging #713 the build supports Java versions from 8 to 23, but future changes could break compatibility if no tested in CI. This PR includes:
Checklist:
New Unit tests were added
Integration tests were added
Test names are meaningful
Feature manually tested and outcome is successful
PR doesn't break any of the earlier features for end users
PR doesn't break the HTML report features directly
/targetfolder and they look finePR doesn't break any HTML report features indirectly
Branch build passed in CI
No 'package.*' in the imports
Relevant DOcumentation page added or updated with clear instructions and examples for the end user
Http test added to
http-testingmodule(if applicable) ?Kafka test added to
kafka-testingmodule(if applicable) ?