-
-
Notifications
You must be signed in to change notification settings - Fork 442
ISSUE-708 # Rename the modules with prefix as -examples #710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISSUE-708 # Rename the modules with prefix as -examples #710
Conversation
|
Hi @poseidontor , thank you for the PR. Give a CI run now, also let me have a look soon. |
pom.xml
Outdated
| <module>http-testing</module> | ||
| <module>kafka-testing</module> | ||
| <module>junit5-testing</module> | ||
| <module>http-testing-example</module> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello mate, all there were supposed to be "http-testing-examples" ending with "s" as per the AC I suppose.
Do you have any reason to make it without "s" (example for SEO stuffs etc, not sure though).
If not, then can you update if it's not too much of a work for you? possible? Just checking... :)
(if it's a lot of work involved, we will think of keeping as it is currentluy as it won't affect it functionaly I think)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nirmalchandra I have updated it to "examples". Sorry it was a miss from my end.
Issue:708 # Rename the modules with prefix as -examples Issue:708 # Rename the modules with prefix as -examples
d478f9f to
b8705ce
Compare
|
@poseidontor , you have been added as a collaborator now. You can join by accepting the invitation here. |
|
Hi @poseidontor , can you resolve the merge conflicts please as mentioned above? Looks like only 1 file only.
Then, we should be good to merge. Many Thanks |
|
Hi @authorjapps, Done! |
Rename the modules with prefix as -examples
Fixes Issue
PR Branch
https://github.com/poseidontor/zerocode/tree/rename_example_prefix
Motivation and Context
Checklist:
New Unit tests were added
Integration tests were added
Test names are meaningful
Feature manually tested and outcome is successful
PR doesn't break any of the earlier features for end users
Branch build passed in CI
No 'package.*' in the imports
Relevant Documentation page added or updated with clear instructions and examples for the end user
Http test added to
http-testingmodule(if applicable) ?Kafka test added to
kafka-testingmodule(if applicable) ?