Skip to content

Conversation

@poseidontor
Copy link
Collaborator

Rename the modules with prefix as -examples

Fixes Issue

  • Renamed http-testing, kafka-testing, junit5-testing with suffix -example
  • Updated the root pom.xml to reflect new module names.
  • Updated values in each renamed module's pom.xml.

PR Branch
https://github.com/poseidontor/zerocode/tree/rename_example_prefix

Motivation and Context

Checklist:

  • New Unit tests were added

    • Covered in existing Unit tests
  • Integration tests were added

    • Covered in existing Integration tests
  • Test names are meaningful

  • Feature manually tested and outcome is successful

  • PR doesn't break any of the earlier features for end users

    • WARNING! This might break one or more earlier earlier features, hence left a comment tagging all reviewrs
  • Branch build passed in CI

  • No 'package.*' in the imports

  • Relevant Documentation page added or updated with clear instructions and examples for the end user

    • Not applicable. This was only a code refactor change, no functional or behaviourial changes were introduced
  • Http test added to http-testing module(if applicable) ?

    • Not applicable. The changes did not affect HTTP automation flow
  • Kafka test added to kafka-testing module(if applicable) ?

    • Not applicable. The changes did not affect Kafka automation flow

@poseidontor poseidontor marked this pull request as ready for review April 27, 2025 04:50
@poseidontor poseidontor changed the title DRAFT PR ISSUE-708 # Rename the modules with prefix as -examples ISSUE-708 # Rename the modules with prefix as -examples Apr 27, 2025
@nirmalchandra
Copy link
Collaborator

Hi @poseidontor , thank you for the PR. Give a CI run now, also let me have a look soon.
The CI build is in-progress here.
Once it turns Green, we should be able to merge this.

@authorjapps authorjapps linked an issue Apr 27, 2025 that may be closed by this pull request
pom.xml Outdated
<module>http-testing</module>
<module>kafka-testing</module>
<module>junit5-testing</module>
<module>http-testing-example</module>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello mate, all there were supposed to be "http-testing-examples" ending with "s" as per the AC I suppose.
Do you have any reason to make it without "s" (example for SEO stuffs etc, not sure though).

If not, then can you update if it's not too much of a work for you? possible? Just checking... :)

(if it's a lot of work involved, we will think of keeping as it is currentluy as it won't affect it functionaly I think)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nirmalchandra I have updated it to "examples". Sorry it was a miss from my end.

Issue:708 # Rename the modules with prefix as -examples

Issue:708 # Rename the modules with prefix as -examples
@poseidontor poseidontor force-pushed the rename_example_prefix branch from d478f9f to b8705ce Compare April 28, 2025 08:36
@authorjapps
Copy link
Owner

@poseidontor , you have been added as a collaborator now. You can join by accepting the invitation here.

@authorjapps
Copy link
Owner

Hi @poseidontor , can you resolve the merge conflicts please as mentioned above? Looks like only 1 file only.

kafka-testing/src/test/resources/kafka/produce/negative/test_kafka_produce_from_worng_filename.json

Then, we should be good to merge.

Many Thanks

@poseidontor
Copy link
Collaborator Author

Hi @poseidontor , can you resolve the merge conflicts please as mentioned above? Looks like only 1 file only.

kafka-testing/src/test/resources/kafka/produce/negative/test_kafka_produce_from_worng_filename.json

Then, we should be good to merge.

Many Thanks

@poseidontor poseidontor reopened this Jun 20, 2025
@poseidontor
Copy link
Collaborator Author

Hi @poseidontor , can you resolve the merge conflicts please as mentioned above? Looks like only 1 file only.

kafka-testing/src/test/resources/kafka/produce/negative/test_kafka_produce_from_worng_filename.json

Then, we should be good to merge.

Many Thanks

Hi @authorjapps, Done!

@nirmalchandra nirmalchandra merged commit 8bb4502 into authorjapps:master Jun 20, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename the modules with prefix as -examples

3 participants