Whm/volcreate acls #15
Conversation
Update volcreate processing of ACLs to allow volume creation of volumes with no ACLs to proceed without warnings.
| die 'Failed to backup volume (status ', ($? >> 8), ")\n"; | ||
| } | ||
|
|
||
| # Set the acls on the volume |
There was a problem hiding this comment.
If the backup volume is created before the setting of the optional root acls, then the created .backup will not be protected by those acls.
| # Set the acls on the volume | ||
| my @this_acl_list = get_acl_list($volume, @acls); | ||
| if (scalar(@this_acl_list) > 0) { | ||
| @cmd = ($VOS, 'setrootacl'); |
There was a problem hiding this comment.
This is setting the volume root directory acl.
Should "volcreate" also provide for an option of setting the volume maximum acl?
"vos setmaxacl". The volume maximum acl is the maximum set of rights that can be granted by users that have administrator privilege on directories, files, etc.
Should "volcreate" also permit the volume owner to be assigned? "vos setowner". The volume owner is a "pts id" (user or group). The volume owner is permitted to fetch the contents of all directories, symlinks and mountpoints. The volume owner may also modify ACLs on all objects in the volume.
|
I will re-order the backup volume and root acl setting. I will need to think a bit how to add support for setmaxacl. The original command line used only positional arguments and the last arguments could be any number of ACLs. setmacacl also needs to allow for an arbitrary number of ACLs. It makes sense to be to add support for setmaxacl as a command line switch, e.g. --setmacacl="user access user2 access". I think it would be a good time to check that all of the positional arguments can be specified as switches. It might make sense to also add support for a configuration file similar to volcreate=logs to allow the specification of defaults selected with regex's. If you have an opinion or suggestion let me know. I am traveling right now and won't be back to a place where I can work on this until Thursday. |
Thanks
I agree that it would be a good idea to review switches. When using the vos command line suite the setting of volume root acl, volume max acl, volume ownership, etc would all be performed as separate commands. Whereas voscreate is attempting to accept all of the settings on a single command line. Since each ACL is really a list of ACEs (names_set, rights) it cannot be parsed correctly when relying upon positional input.
That is a good idea. @macrotex, what is your expected use case? |
Update volcreate processing of ACLs to allow volume creation of volumes with no ACLs to proceed without warnings.