fix(doctrine): escape values with % or _ in search filter
#7653
+40
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
force-pushed
the
escapeLikeValue
branch
from
2878001 to
f1f04f7
Compare
soyuka
reviewed
Jan 8, 2026
| 'LOWER('.$field.')', | ||
| ':'.$parameterName | ||
| )); | ||
| $likeExpression = 'LOWER('.$field.') LIKE :'.$parameterName.' ESCAPE \'\\\''; |
Member
There was a problem hiding this comment.
I've never used ESCAPE is this compatible with all the doctrine platforms?
Contributor
Author
There was a problem hiding this comment.
I cannot be fully sure and I'm open to feedback about it. But this seems to be a basic "SQL" clause.
On the other side, I couldn't make the tests to work with the initial
$queryBuilder->expr()->like
The issue was that the test run on pdo sqlite which had trouble with a search like \ ; seems like \ is not the character used by default to escape like search for pdo sqlite (while it worked fine on mysql and pgsql).
So the other solution was to keep $queryBuilder->expr()->like( and
- ignoring the test for
\ - not being sure that
\was used to escape on every existing platform.
This didn't seem better to me
soyuka
changed the title
% or _% or _ in search filter
Member
|
Thanks! |
Contributor
Author
You're welcome ; should we backport this fix to the SearchFilter ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
%and_are reserved characters which need to be escaped when used in a LIKE query.Before this PR
'/chickens?namePartial=%',returns 2 results ; now it correctly returns 0.