[python] support read after update by shard of data evolution table #7157
+694
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XiaoHongbo-Hope
changed the title
XiaoHongbo-Hope
changed the title
JingsongLi
reviewed
Feb 2, 2026
| row_tracking_enabled: bool, | ||
| system_fields: dict): | ||
| system_fields: dict, | ||
| requested_field_names: Optional[List[str]] = None): |
Contributor
There was a problem hiding this comment.
You should just use fields: List[DataField]?
| """Ensure _ROW_ID and _SEQUENCE_NUMBER are not null (per SpecialFields).""" | ||
| fields = [] | ||
| for field in schema: | ||
| if field.name == SpecialFields.ROW_ID.name or field.name == SpecialFields.SEQUENCE_NUMBER.name: |
Contributor
Author
There was a problem hiding this comment.
Why it can be nullable?
A bug here. Nullable info of row-tracking system fields is lost during _assign_row_tracking. Opened a separate PR #7174 to fix it.
XiaoHongbo-Hope
force-pushed
the
shards_read
branch
from
befde12 to
72ffd99
Compare
XiaoHongbo-Hope
force-pushed
the
shards_read
branch
from
72ffd99 to
7e5f55a
Compare
added 2 commits
February 3, 2026 11:54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When the user updates a column for only one shard (e.g. ShardTableUpdator runs shard 0 only and writes new column
d), full table read fails:Only that shard’s files have the new column; other files do not. Concat batches → schema mismatch → crash. To fix the issue, we support data evolution shard read.
Tests
API and Format
Documentation