binfmt: refactor loadable module cleanup mechanism #17954
+4
−157
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the loadable binary module cleanup mechanism to remove the
deprecated
group_exitinfo()function and simplify the module unload process.The changes eliminate unnecessary critical section locking in the exec path and
integrate module unload setup directly into the task initialization sequence.
Changes
The refactoring involves several related changes across the binary format and
group management subsystems:
binfmt/binfmt_exec.c - Simplify exec_internal():
irqstate_t flagsvariable and related critical section managemententer_critical_section()andsched_lock()callsgroup_exitinfo()call and associated error handlingbinfmt/binfmt_execmodule.c - Move unload setup to exec_module():
tcb->group->tg_bininfo = binpunder CONFIG_BINFMT_LOADABLEinclude/nuttx/sched.h - Remove deprecated interface:
group_exitinfo()function declarationsched/group/CMakeLists.txt and Make.defs:
group_exitinfo.csource file from buildBenefits
Testing
Tested on:
Impact