NIFI-15387 Re-enabled tests TestFetchFile, TestListFile and TestPutFile to run on Windows.

[dan-s1]

Summary

NIFI-15387
Re-enabled nine out of eleven tests in TestFetchFile, thirteen out of eighteen in TestListFile and eight of nine tests in TestPutFile to run on Windows. Also for the disabled test testNonReadableFile in StandardFileResourceServiceTest specified a disabled reason as it is the same reason for disabling testPutFile in TestPutFile. In addition, I also followed some of the Intellij suggestions for cleaning up the code.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

• Apache NiFi Jira issue created

Pull Request Tracking

• Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
• Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

• Pull Request based on current revision of the main branch
• Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

• Build completed using ./mvnw clean install -P contrib-check
  • JDK 21
  • JDK 25

Licensing

• New dependencies are compatible with the Apache License 2.0 according to the License Policy
• New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

• Documentation formatting appears as expected in rendered files

[exceptionfactory]

Thanks for working on this @dan-s1. It looks like at least one test is failing on Windows with the current changes, it seems like the message pattern needs to be simplified to avoid the tight coupling to the message.

TestListFile.testFilterPathPattern:653->assertVerificationOutcome:945 Expected verification result to match pattern [Successfully listed .* Found 4 objects.  Of those, 1 matches the filter.].  Actual explanation was: Successfully listed contents of Local Directory [D:\a\nifi\nifi\nifi-extension-bundles\nifi-standard-bundle\nifi-standard-processors\target\test\data\in].  Found 4 objects.  Of those, 0 match the filter. ==> expected: <true> but was: <false>

[dan-s1]

@exceptionfactory I am not sure that is the problem as that message works on all the other boxes but for Windows. I think there is something with the filter logic on windows when the filter path is on pattern subdir2 (which is the last part of test testFilterPathPattern). I have tried a few fixes which seem more like empty stabs. I could for now just disable this particular test for Windows although that does not seem satisfying.

[exceptionfactory]

@exceptionfactory I am not sure that is the problem as that message works on all the other boxes but for Windows. I think there is something with the filter logic on windows when the filter path is on pattern subdir2 (which is the last part of test testFilterPathPattern). I have tried a few fixes which seem more like empty stabs. I could for now just disable this particular test for Windows although that does not seem satisfying.

Yes, it does appear to be an issue with the directory pattern matching on Windows. I'm fine with disabling only that particular test on Windows. It is probably worth creating a new Jira issue to review that particular test method more closely if you are unable to find a satisfactory solution for this particular pull request.

[dan-s1]

@exceptionfactory
If I disable it can I leave off a reason for now?

[exceptionfactory]

@exceptionfactory If I disable it can I leave off a reason for now?

I would include a reason indicating an apparent filter mismatch or something along those lines, but it is fine to leave out a reason if you prefer.