Skip to content

Fix typo: 'textOccurencesInLog' -> 'textOccurrencesInLog' #11611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GaoSSR wants to merge 2 commits into
base: master
Choose a base branch
from
+12 −4
Open

Fix typo: 'textOccurencesInLog' -> 'textOccurrencesInLog' #11611

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
666f1df
Fix typo: 'textOccurencesInLog' -> 'textOccurrencesInLog'
GaoSSR Dec 30, 2025
35d9b05
Use deprecate-and-replace approach for API compatibility
GaoSSR Dec 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions its/core-it-support/maven-it-helper/src/main/java/org/apache/maven/it/Verifier.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,25 +594,33 @@ public void verifyTextNotInLog(String text) throws VerificationException, IOExce
}

public static void verifyTextNotInLog(List<String> lines, String text) throws VerificationException {
if (textOccurencesInLog(lines, text) > 0) {
if (textOccurrencesInLog(lines, text) > 0) {
throw new VerificationException("Text found in log: " + text);
}
}

public static void verifyTextInLog(List<String> lines, String text) throws VerificationException {
if (textOccurencesInLog(lines, text) <= 0) {
if (textOccurrencesInLog(lines, text) <= 0) {
throw new VerificationException("Text not found in log: " + text);
}
}

public long textOccurrencesInLog(String text) throws IOException {
return textOccurencesInLog(loadLogLines(), text);
return textOccurrencesInLog(loadLogLines(), text);
}

public static long textOccurencesInLog(List<String> lines, String text) {
public static long textOccurrencesInLog(List<String> lines, String text) {
Copy link
Contributor

@elharo elharo Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a public method. Not sure we can just rename it. Might have to deprecate and replace depending on when it was added

return lines.stream().filter(line -> stripAnsi(line).contains(text)).count();
}

/**
* @deprecated Use {@link #textOccurrencesInLog(List, String)} instead
*/
@Deprecated
public static long textOccurencesInLog(List<String> lines, String text) {
return textOccurrencesInLog(lines, text);
}

/**
* Checks whether the specified line is just an error message from Velocity. Especially old versions of Doxia employ
* a very noisy Velocity instance.
Expand Down