JCR-5195: Utilities for 'safe' creation of XML document builders #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…do changes in classes not ready
kwin
reviewed
Oct 2, 2025
| /** | ||
| * @return a "safe" {@link DocumentBuilderFactory} | ||
| */ | ||
| public static DocumentBuilderFactory documentBuilderFactory() { |
Member
There was a problem hiding this comment.
Suggested change
| public static DocumentBuilderFactory documentBuilderFactory() { | |
| public static DocumentBuilderFactory safeDocumentBuilderFactory() { | |
jackrabbit-jcr-commons/src/main/java/org/apache/jackrabbit/commons/xml/Factory.java
Outdated
Show resolved
Hide resolved
kwin
reviewed
Oct 6, 2025
| /** | ||
| * Factory for "safe" instances of XML parsers (wrt XXE etc.). | ||
| */ | ||
| public class Factories { |
Member
There was a problem hiding this comment.
I would still go for a more specific classname. Otherwise things like "Organize Imports" might easily return a clashing class with same generic name. Same reason why XMLConstants in javax.xml is not just named Constants
Contributor
Author
There was a problem hiding this comment.
What's (to me) is more convincing is:
$ find . -name *XML*.java
./jackrabbit-core/src/main/java/org/apache/jackrabbit/core/persistence/xml/XMLPersistenceManager.java
./jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/lucene/DefaultXMLExcerpt.java
./jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/lucene/WeightedXMLExcerpt.java
./jackrabbit-jcr-commons/src/main/java/org/apache/jackrabbit/util/XMLChar.java
./jackrabbit-jcr-commons/src/main/java/org/apache/jackrabbit/util/XMLUtil.java
./jackrabbit-jcr-tests/src/main/java/org/apache/jackrabbit/test/XMLChar.java
But the result is the same...
…name Factory class again
|
kwin
approved these changes
Oct 7, 2025
mbaedke
approved these changes
Oct 7, 2025
reschke
added a commit
that referenced
this pull request
Jan 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bikeshedding of class and method names expected :-)
EDIT: unfortunately, we indeed have cases where entity resolution currently is needed; *ConfigurationParser and SearchIndex.