refactor: Clear setup and validation in HoodieTableFactory #18010
+84
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
geserdugarov
changed the title
HoodieTableFactory
geserdugarov
commented
Jan 27, 2026
| setupKeyGenRelatedOptions(conf, context.getCatalogTable()); | ||
| ResolvedSchema schema = context.getCatalogTable().getResolvedSchema(); | ||
| setupConfOptions(conf, context.getObjectIdentifier(), context.getCatalogTable(), schema); | ||
| setupAdditionalOptions(conf, context.getObjectIdentifier(), schema.toPhysicalRowDataType().notNull().getLogicalType()); |
Contributor
Author
There was a problem hiding this comment.
The code block up to this line is repeated in createDynamicTableSink, but I suppose it's simpler to understand of what is going on here this way.
geserdugarov
force-pushed
the
master-refac-factory
branch
3 times, most recently
from
db563d4 to
c864d96
Compare
geserdugarov
commented
Jan 27, 2026
| // set common parameters | ||
| conf.setString(FlinkOptions.TABLE_NAME.key(), context.getObjectIdentifier().getObjectName()); | ||
| conf.setString(FlinkOptions.DATABASE_NAME.key(), context.getObjectIdentifier().getDatabaseName()); | ||
| setupKeyGenRelatedOptions(conf, context.getCatalogTable()); |
Contributor
Author
There was a problem hiding this comment.
The principal change is here, where we setup key related options first with possible overwrites, and only then check them in sanityCheck.
geserdugarov
force-pushed
the
master-refac-factory
branch
from
c864d96 to
53322ff
Compare
geserdugarov
force-pushed
the
master-refac-factory
branch
from
53322ff to
2d76d83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the issue this Pull Request addresses
For separate discussion of
HoodieTableFactorysimplification started in #17994.Summary and Changelog
This PR is intended to simplify understanding the flow of Hoodie options set and validation in
HoodieTableFactory.Impact
No impact
Risk Level
None
Documentation Update
No need
Contributor's checklist