This repository was archived by the owner on May 12, 2021. It is now read-only.
Rebase and fixup for the 396 networking patchset #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: marios <[email protected]> TrackedAt: http://tracker.deltacloud.org/patch/9884a9fb9762cc8cfb11822b83245d3132d27f92
Signed-off-by: marios <[email protected]> TrackedAt: http://tracker.deltacloud.org/patch/105b1e677962fdaf68c9748f10b1dd7ec20cfbff
Signed-off-by: marios <[email protected]> TrackedAt: http://tracker.deltacloud.org/patch/58892c140dcc50ece64969d9b4d4f083dba84642
Loading the XML list of networks and subnets caused Tilt to rais an
exception:
invalid locals key: :@network (keys must be variable names)
Renaming `@network` to `network` (and the same for `@subnet`) in the
views fixed the problem.
Signed-off-by: Tomas Sedovic <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes in the master made the networking patches sent by @marios1 incompatible.
This is a rebase of those patches against the master plus a few fixes so that listing networks and subnets as application/xml works properly.