GH-24157: [C++] Add tests for DayTimeIntervalBuilder #48709
+65
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The
DayTimeIntervalBuilderclass was marked as untested (ARROW-7938). This PR adds dedicated tests to verify the builder's functionality, similar to howTestHalfFloatBuildertestsHalfFloatBuilder.What changes are included in this PR?
TestDayTimeIntervalBuildertest class with three test cases:TestAppend: Tests basic append operations including nulls and unsafe appendTestBulkAppend: Tests bulk append operations with various signaturesTestConstructors: Tests all constructor variations (default, with pool, with explicit type)builder_time.hsince the class is now testedAre these changes tested?
Yes, the tests I mentioned are added.
Are there any user-facing changes?
No, test-only.