Fix unnecessary DAG version churn when DAG file paths change #60799
+133
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
requested review from
amoghrajesh,
ashb,
bolkedebruin and
potiuk
as code owners
Add exclude_module parameter to qualname() that returns only the qualified name without module prefix. This prevents unnecessary DAG version churn when bundle paths change (e.g., version or timestamp-based folders). The module name contains a path-derived hash that changes with each deployment, causing new `SerializedDagModel` entries even when DAG code is unchanged.
kaxil
force-pushed
the
fix-python-callable-name-stability
branch
from
01f2900 to
d7c6c22
Compare
amoghrajesh
approved these changes
Jan 20, 2026
Comment on lines
1038
to
1069
| # Store python_callable_name instead of python_callable. | ||
| # exclude_module=True ensures stable names across bundle version changes. | ||
| python_callable = op.partial_kwargs.get("python_callable", None) | ||
| if python_callable: | ||
| callable_name = qualname(python_callable) | ||
| serialized_op["partial_kwargs"]["python_callable_name"] = callable_name | ||
| serialized_op["partial_kwargs"]["python_callable_name"] = qualname( | ||
| python_callable, exclude_module=True | ||
| ) | ||
| del serialized_op["partial_kwargs"]["python_callable"] | ||
|
|
||
| serialized_op["_is_mapped"] = True | ||
| return serialized_op | ||
|
|
||
| @classmethod | ||
| def serialize_operator(cls, op: SdkOperator) -> dict[str, Any]: | ||
| return cls._serialize_node(op) | ||
|
|
||
| @classmethod | ||
| def _serialize_node(cls, op: SdkOperator) -> dict[str, Any]: | ||
| """Serialize operator into a JSON object.""" | ||
| serialize_op = cls.serialize_to_json(op, cls._decorated_fields) | ||
|
|
||
| if not op.email: | ||
| # If "email" is empty, we do not need to include other email attrs | ||
| for attr in ["email_on_failure", "email_on_retry"]: | ||
| if attr in serialize_op: | ||
| del serialize_op[attr] | ||
|
|
||
| # Detect if there's a change in python callable name | ||
| # Store python_callable_name for change detection. | ||
| # exclude_module=True ensures stable names across bundle version changes. | ||
| python_callable = getattr(op, "python_callable", None) | ||
| if python_callable: | ||
| callable_name = qualname(python_callable) | ||
| serialize_op["python_callable_name"] = callable_name | ||
| serialize_op["python_callable_name"] = qualname(python_callable, exclude_module=True) |
Contributor
There was a problem hiding this comment.
Was just reviewing in consideration to collision between tasks but since its scoped deep in the nested structure, we are good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When DAG files are loaded from paths that change between deployments (e.g., versioned directories), the
python_callable_namein serialized DAGs changes even when the actual DAG code is unchanged.This happens because
qualname()includes the module name, which contains a hash derived from the file path viaget_unique_dag_module_name(). When the path changes, the module name changes, causing:python_callable_namevaluesdag_hashSerializedDagModelentries on every deploymentSolution
Add
exclude_moduleparameter toqualname()that returns only the qualified name without the module prefix:Use this in operator serialization to ensure
python_callable_nameis stable across deployments.