Add E2E test to verify XComs page displays XCom entries correctly #59358 #60620
+342
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haseebmalik18
requested review from
choo121600 and
vatsrahul1001
as code owners
haseebmalik18
force-pushed
the
feature/xcoms-e2e-tests
branch
from
fa17ae0 to
17c0ab0
Compare
Contributor
|
Nice! Added few review comments |
haseebmalik18
force-pushed
the
feature/xcoms-e2e-tests
branch
from
17c0ab0 to
77eeb83
Compare
haseebmalik18
requested review from
bbovenzi,
guan404ming,
pierrejeambrun,
ryanahamilton and
shubhamraj-git
as code owners
Contributor
Author
|
@vatsrahul1001 Made the changes |
haseebmalik18
force-pushed
the
feature/xcoms-e2e-tests
branch
2 times, most recently
from
9785def to
420bbd9
Compare
Contributor
Thanks @haseebmalik18, this is great progress. I noticed webkit and firefox tests are flaky and needed retry https://github.com/apache/airflow/actions/runs/21125402571/job/60747088841?pr=60620. Can you look at it? |
haseebmalik18
force-pushed
the
feature/xcoms-e2e-tests
branch
4 times, most recently
from
5440e75 to
e8235bf
Compare
haseebmalik18
force-pushed
the
feature/xcoms-e2e-tests
branch
from
e8235bf to
bbbe111
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add comprehensive E2E tests for the XComs page (
/xcoms) to verify XCom entries display correctly.closes: #59358
Changes
Created
XComsPage.ts- Page Object Model for XComs page interactionsCreated
xcoms.spec.ts- E2E test specification with 8 test cases