-
Notifications
You must be signed in to change notification settings - Fork 649
docs: 增加旭日图&treemap文档 #2131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: 增加旭日图&treemap文档 #2131
Conversation
Summary of ChangesHello @tangying1027, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求新增了旭日图和矩形树图的文档页面。这些新增内容旨在为用户提供关于如何使用和配置这些层级数据可视化图表的全面指南,包括使用示例、属性描述和数据结构要求。 Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
本次 PR 增加了旭日图(Sunburst)和矩形树图(Treemap)的 API 文档,内容翔实,有助于开发者理解和使用这两个图表组件。我对矩形树图的文档提出了一些修改建议,主要为了解决描述与示例代码不一致的问题,使其更加清晰和准确。具体修改包括:移除多余的空标题、修正 data 属性的描述以明确其对扁平数据和层级数据的支持、以及更新“数据结构”部分的说明以使其与示例数据保持一致。旭日图的文档看起来没有问题。整体上,这是一次很有价值的贡献。
| ## Usage | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
||
| | 属性名 | 类型 | 描述 | | ||
| | --------- | ------------------------------ | -------------------------------- | | ||
| | data | `Array` | 数据源,必须是具有层级结构的数组 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
||
| ## 数据结构 | ||
|
|
||
| 矩形树图需要具有层级结构的数据,示例如下: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: |
Checklist
npm testpassesDescription of change