-
Notifications
You must be signed in to change notification settings - Fork 1
Chore/PJH-80: Shopify Workflow #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…nto chore/PJH-80_shopify_deploy
The merge-base changed after approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file change looks good to me, but the note from your PR Summary is a little confusing. I'm not too familiar with Shopify and Gadget yet but should the Shopfiy example be using re-useable actions related to Shopify and not Gadget?
I noticed that there is a branch called chore/PJH-80_shopify_deploy. I just wanted to make sure you didn't pick the wrong branch that's all.
In your summary you have:
shopify-deploy:
uses: aligent/workflows/.github/workflows/gadget-deploy.yml@chore/PJH-80_gadget_deploy
Yeah good catch, a copy and paste error from gadget Workflow PR, have updated (: Should be
|
Description of the proposed changes
Screenshots (if applicable)
Other solutions considered (if any)
Notes to PR author
Deploying to Shopify example
Notes to reviewers
ℹ️ When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback