fix(test): テストにおいてAiScriptの値以外にeq関数を適用している問題を修正 #1010
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
test/syntax.tsのmetaテストスイートにおいて、getMeta()関数が返すMapに、AiScriptの値を比較するeq()関数ではなくexpect().toStrictEqual()を使用するようにします。Why
eq()関数は、渡された2つのオブジェクトのtypeプロパティとvalueプロパティにアクセスし、それぞれが等しいことを検証します。Mapにはtypeプロパティとvalueプロパティが存在しないため、eq()関数によってundefinedが取り出され、常に検証が成功するようになっています。expect().toStrictEqual()を使用することで正しくMapの内容を比較するようになります。Additional info (optional)