Skip to content

fix: url poisoning via user-controlled input (take 2) #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rofe merged 2 commits into from
Dec 9, 2025
Merged

fix: url poisoning via user-controlled input (take 2) #685

rofe merged 2 commits into from
Dec 9, 2025

Conversation

@rofe
Copy link
Contributor

@rofe rofe commented Dec 7, 2025

  • Adds back fix for SITES-33256 initially added in #672
  • Fixes regression causing revert in #684 by preserving dots in folder names
  • Adds protection against path traversal attacks

https://j33256b--da-live--adobe.aem.page/edit

@rofe rofe requested a review from auniverseaway December 7, 2025 11:52
@aem-code-sync
Copy link

aem-code-sync bot commented Dec 7, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync
Copy link

aem-code-sync bot commented Dec 7, 2025

Page Scores Audits Google
📱 /edit PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /edit PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@rofe rofe merged commit 07db99d into main Dec 9, 2025
5 checks passed
@rofe rofe deleted the j33256b branch December 9, 2025 19:05
auniverseaway added a commit that referenced this pull request Dec 10, 2025
@auniverseaway
Revert "fix: url poisoning via user-controlled input (take 2) (#685)"
ac77bb0 
This reverts commit 07db99d.
@auniverseaway auniverseaway mentioned this pull request Dec 10, 2025
Merged
auniverseaway added a commit that referenced this pull request Dec 10, 2025
@auniverseaway
Revert "fix: url poisoning via user-controlled input (take 2) (#685)" (…
9c60c1f 
…#687)

This reverts commit 07db99d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@auniverseaway auniverseaway auniverseaway approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rofe @auniverseaway