Fix crash when no tab is selected in ChannelTabs.onSwitch #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes a startup crash caused by `this.settings.tabs.findIndex(...)` returning -1 when no tab is selected. Accessing `.minimized` on an undefined tab caused: TypeError: Cannot read properties of undefined (reading 'minimized') We now check if the index is valid before accessing `.minimized`, and default to `false` if not. This fixes: sentry.395064ce93b61e02.js:14 [PluginManager] ChannelTabs v2.7.5 could not be started. TypeError: Cannot read properties of undefined (reading 'minimized')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a startup crash caused by
this.settings.tabs.findIndex(...)returning -1 when no tab is selected.Accessing
.minimizedon an undefined tab caused: TypeError: Cannot read properties of undefined (reading 'minimized')We now check if the index is valid before accessing
.minimized, and default tofalseif not.This fixes:
sentry.395064ce93b61e02.js:14 [PluginManager] ChannelTabs v2.7.5 could not be started. TypeError: Cannot read properties of undefined (reading 'minimized')