-
Notifications
You must be signed in to change notification settings - Fork 534
Update the version of a2a-sdk version in pyproject.toml #425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
--------------------------------------------------------- Starting CLI Client... The script will exit after the client finishes. --------------------------------------------------------- × Failed to download `a2a-sdk==0.3.0` ├─▶ Failed to fetch: │ `https://files.pythonhosted.org/packages/a5/92/16bfbc2ef0ef037c5860ef3b13e482aeb1860b9643bf833ed522c995f639/a2a_sdk-0.3.0-py3-none-any.whl` ╰─▶ HTTP status client error (404 Not Found) for url (https://files.pythonhosted.org/packages/a5/92/16bfbc2ef0ef037c5860ef3b13e482aeb1860b9643bf833ed522c995f639/a2a_sdk-0.3.0-py3-none-any.whl) help: `a2a-sdk` (v0.3.0) was included because `a2a-mcp` (v0.1.0) depends on `a2a-sdk` Shutting down background processes...
Summary of ChangesHello @QJ-0511, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical dependency resolution issue by updating the version constraint for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the a2a-sdk dependency in pyproject.toml to resolve a download failure for an older, unavailable version. The change correctly raises the minimum version requirement. My review points out a discrepancy between the version number mentioned in the pull request description (0.3.22) and the one implemented in the code (>=0.3.10), with a suggestion to align them for consistency and to ensure the intended fix is applied.
| requires-python = ">=3.13" | ||
| dependencies = [ | ||
| "a2a-sdk[sql]>=0.3.0", | ||
| "a2a-sdk[sql]>=0.3.22", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request description mentions that updating to version 0.3.22 would fix the issue, but the dependency has been updated to >=0.3.10. For consistency and to ensure the intended fix is applied, it would be better to align the code with the description. Would you consider updating this to >=0.3.22?
| "a2a-sdk[sql]>=0.3.22", | |
| "a2a-sdk[sql]>=0.3.22", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's consistent now.
The version "0.3.0" is not applicable for "a2a-sdk" anymore. Running the script "samples/python/agents/a2a_mcp/run.sh" will generates the following issues:
Updating the version to 0.3.22 could fix the issue.