-
Notifications
You must be signed in to change notification settings - Fork 532
feat(ag2): add AG2 reviewer sample and demo UI (clean) #422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @elCaptnCode, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the AG2 agent sample by introducing a clean, modular structure and an interactive, browser-based demo UI. It separates the core agent logic from the presentation layer, making the sample easier to understand and extend. Additionally, it improves the robustness of the 'mypy' code review tool integration by addressing Windows-specific file handling, ensuring a smoother developer experience across different operating systems. The updated documentation guides users through the new server-client architecture and the visual demonstration capabilities. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new AG2 reviewer sample with a demo UI. The changes are well-structured, separating the core agent logic from the new demo UI. The Windows compatibility fix for mypy is a good improvement. However, the pull request cannot be merged in its current state due to several unresolved merge conflicts in README.md, a2a_python_reviewer.py, and pyproject.toml. These must be resolved first. Additionally, I've provided some suggestions to improve the new demo UI's JavaScript for better performance and security, and pointed out some dead code in the WebSocket server.
…ct reviewer URL into demo HTML
|
PR #422 — Smoke test and fixes applied Smoke test (local, Windows venv):
Fixes included in this branch:
Reproduction steps (local):
If you want, I can (A) attach logs to the PR, (B) push a tiny README in |
What: Clean PR with only the AG2 sample folder (
samples/python/agents/ag2) and separated demo UIDetails:
samples/python/agents/ag2/demo/containingui.html,assets/, anddemo/websocket.py(presentation UI only)samples/python/agents/ag2/mypytool handling ina2a_python_reviewer.py(tempfile delete=False + manual cleanup)How to test:
Notes: This PR contains only the AG2 sample folder; unrelated dotnet build artifacts and other sample changes were excluded.