chore: update 1.0-dev with main and merge it #600

NasserAAA · 2025-12-19T12:59:00Z

Description

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Follow the CONTRIBUTING Guide.
Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
- Important Prefixes for release-please:
  - fix: which represents bug fixes, and correlates to a SemVer patch.
  - feat: represents a new feature, and correlates to a SemVer minor.
  - feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.
Ensure the tests and linter pass (Run bash scripts/format.sh from the repository root to format)
Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Luca Muscariello <[email protected]> Co-authored-by: Yaroslav <[email protected]> Co-authored-by: Agent2Agent (A2A) Bot <[email protected]> Co-authored-by: agil.yolchuyev <[email protected]> Co-authored-by: yolagil <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Holt Skinner <[email protected]> Co-authored-by: Luca Muscariello <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

…the specification (a2aproject#511) Commit: a2aproject/A2A@0a9f629 This PR introduces support for the new `tasks/list` method, including: - Automatically generated type definitions from the specification. - Complete client-side and server-side implementations. Fixes a2aproject#515 🦕 --------- Co-authored-by: lkawka <[email protected]> Co-authored-by: lkawka <[email protected]> Co-authored-by: Holt Skinner <[email protected]>

Co-authored-by: Iva Sokolaj <[email protected]> Co-authored-by: Agent2Agent (A2A) Bot <[email protected]> Co-authored-by: Tadaki Asechi <[email protected]> Co-authored-by: tadaki <[email protected]> Co-authored-by: Holt Skinner <[email protected]> Co-authored-by: TadakiAsechi <[email protected]> Co-authored-by: TadakiAsechi <[email protected]>

….0-dev

gemini-code-assist · 2025-12-19T12:59:36Z

Summary of Changes

Hello @NasserAAA, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a comprehensive list_tasks feature, allowing users to efficiently query and retrieve tasks from the A2A system. It provides robust filtering options and pagination support, enhancing task management and data retrieval across various communication protocols. The changes span client interfaces, server-side request handlers, and underlying task storage mechanisms, ensuring a consistent and functional experience.

Highlights

New list_tasks Method: Introduced a new list_tasks method across the client and server, enabling retrieval of tasks with filtering and pagination capabilities.
Pagination and Filtering: The list_tasks method supports filtering by context_id, status, last_updated_after, and includes pagination with page_size and page_token.
Transport Layer Implementation: Implemented the list_tasks functionality across gRPC, JSON-RPC, and REST transport layers, ensuring broad compatibility.
Task Store Integration: Updated both in-memory and database task stores to support the new list_tasks method, including sorting by update time and handling pagination tokens.
Utility Functions: Added utility functions for encoding and decoding page tokens, and a default page size constant for task listing.

Ignored Files

Ignored by pattern: CHANGELOG.md (1)
- CHANGELOG.md

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces the list_tasks functionality, allowing clients to retrieve a paginated and filterable list of tasks. The changes are extensive and well-implemented across the entire stack, including client interfaces, transports (gRPC, JSON-RPC, REST), server-side handlers, and data stores (in-memory and database). The new database query for listing tasks includes robust keyset pagination, which is excellent for performance. The test coverage for the new feature is thorough, with unit, integration, and parameterized tests ensuring correctness and consistency. I've found a couple of minor leftover debug print statements that should be removed. Overall, this is a high-quality contribution.

src/a2a/utils/task.py

tests/integration/test_client_server_integration.py

NasserAAA · 2026-01-01T02:31:41Z

/gemini review

NasserAAA · 2026-01-01T02:33:22Z

@lkawka @holtskinner

gemini-code-assist

Code Review

This pull request introduces a new list_tasks functionality across the client and server components, enabling agents to retrieve tasks with filtering and pagination. Key changes include adding ListTasksParams and ListTasksResult types, defining abstract list_tasks methods in client and transport interfaces, and implementing these methods for gRPC, JSON-RPC, and REST transports. On the server side, a new on_list_tasks method is added to the default request handler, which interacts with the task store to filter, sort, and paginate tasks, also handling artifact exclusion and history length. The protobuf definitions (a2a_pb2.py, a2a_pb2.pyi, a2a_pb2_grpc.py) were updated to include the new ListTasksRequest and ListTasksResponse messages and RPC method. The DatabaseTaskStore and InMemoryTaskStore were updated to include a list method for retrieving tasks with pagination and filtering, and new utility functions for encoding/decoding page tokens were added. Additionally, the spelling allow list was updated to include 'mariadb', and two debugging print statements were identified in the review comments as needing removal.

gemini-code-assist · 2026-01-01T02:33:39Z

src/a2a/server/tasks/inmemory_task_store.py

+    async def list(
+        self,
+        params: ListTasksParams,
+        context: ServerCallContext | None = None,
+    ) -> TasksPage:
+        """Retrieves a list of tasks from the store."""
+        async with self.lock:
+            tasks = list(self.tasks.values())
+
+        # Filter tasks
+        if params.context_id:
+            tasks = [
+                task for task in tasks if task.context_id == params.context_id
+            ]
+        if params.status and params.status != 'unknown':
+            tasks = [
+                task for task in tasks if task.status.state == params.status
+            ]
+        if params.last_updated_after:
+            last_updated_after_iso = datetime.fromtimestamp(
+                params.last_updated_after / 1000, tz=timezone.utc
+            ).isoformat()
+            tasks = [
+                task
+                for task in tasks
+                if (
+                    task.status.timestamp
+                    and task.status.timestamp >= last_updated_after_iso
+                )
+            ]
+
+        # Order tasks by last update time. To ensure stable sorting, in cases where timestamps are null or not unique, do a second order comparison of IDs.
+        tasks.sort(
+            key=lambda task: (
+                task.status.timestamp is not None,
+                task.status.timestamp,
+                task.id,
+            ),
+            reverse=True,
+        )
+
+        # Paginate tasks
+        total_size = len(tasks)
+        start_idx = 0
+        if params.page_token:
+            start_task_id = decode_page_token(params.page_token)
+            valid_token = False
+            for i, task in enumerate(tasks):
+                if task.id == start_task_id:
+                    start_idx = i
+                    valid_token = True
+                    break
+            if not valid_token:
+                raise ValueError(f'Invalid page token: {params.page_token}')
+        end_idx = start_idx + (params.page_size or DEFAULT_LIST_TASKS_PAGE_SIZE)
+        next_page_token = (
+            encode_page_token(tasks[end_idx].id)
+            if end_idx < total_size
+            else None
+        )
+        tasks = tasks[start_idx:end_idx]
+
+        return TasksPage(
+            next_page_token=next_page_token,
+            tasks=tasks,
+            total_size=total_size,
+        )


The implementation of list in the InMemoryTaskStore could be a performance bottleneck for a large number of tasks. On every call, it converts the entire self.tasks dictionary to a list, then filters, sorts (O(N log N)), and paginates by iterating to find the start index (O(N)).

While this is likely acceptable for testing or small-scale use, if this store is expected to handle a significant number of tasks, consider using a more efficient data structure. For example, maintaining a sorted list or a tree-based structure could improve the performance of filtering and pagination.

gemini-code-assist · 2026-01-01T02:33:39Z

src/a2a/utils/task.py

+    missing_padding = len(encoded_str) % 4
+    if missing_padding:
+        encoded_str += '=' * (4 - missing_padding)
+    print(f'input: {encoded_str}')


This print statement appears to be a leftover from debugging and should be removed.

gemini-code-assist · 2026-01-01T02:33:39Z

tests/integration/test_client_server_integration.py

+    transport = transport_setup.transport
+    handler = transport_setup.handler
+
+    print(handler.on_list_tasks.call_args)


This print statement seems to be a leftover from debugging and should be removed from the test.

lkawka and others added 5 commits November 13, 2025 11:12

Merge remote-tracking branch 'upstream/main' into 1.0-dev

0111633

Merge branch 'main' of https://github.com/NasserAAA/a2a-python into 1…

b4b7e12

….0-dev

NasserAAA requested review from a team and a2a-bot as code owners December 19, 2025 12:59

gemini-code-assist bot reviewed Dec 19, 2025

View reviewed changes

src/a2a/utils/task.py Show resolved Hide resolved

tests/integration/test_client_server_integration.py Show resolved Hide resolved

NasserAAA added 3 commits December 19, 2025 15:27

fix: emulate nulls last for db

bdb9ad8

fix: none yields true issue

021d8cc

chore: allow mariadb in spell check

f2049dc

gemini-code-assist bot reviewed Jan 1, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: update 1.0-dev with main and merge it #600

chore: update 1.0-dev with main and merge it #600

NasserAAA commented Dec 19, 2025 •

edited

Loading

Uh oh!

gemini-code-assist bot commented Dec 19, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

NasserAAA commented Jan 1, 2026

Uh oh!

NasserAAA commented Jan 1, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Jan 1, 2026

Uh oh!

gemini-code-assist bot Jan 1, 2026

Uh oh!

gemini-code-assist bot Jan 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chore: update 1.0-dev with main and merge it #600

Are you sure you want to change the base?

chore: update 1.0-dev with main and merge it #600

Conversation

NasserAAA commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

gemini-code-assist bot commented Dec 19, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

NasserAAA commented Jan 1, 2026

Uh oh!

NasserAAA commented Jan 1, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jan 1, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 1, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 1, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

NasserAAA commented Dec 19, 2025 •

edited

Loading