Skip to content

Conversation

@guglielmo-san
Copy link
Member

Description

ResubscribeTask should not support the type Message as a Response.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @guglielmo-san, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the resubscribeTask API by narrowing its possible return types. It introduces a new type definition that explicitly excludes Message from the stream of events returned by this method, ensuring that consumers of resubscribeTask receive only relevant task-related events and not general messages. This change improves type safety and clarifies the API's contract.

Highlights

  • Type Definition Refinement: A new type A2AStreamEventDataResubscribe has been introduced, which explicitly excludes the Message type from the A2AStreamEventData union, ensuring more precise type definitions for task-related streams.
  • API Signature Update: The resubscribeTask method's return type has been updated across various client components (A2AClient, Client, JsonRpcTransport, Transport interface) to consistently use the more specific A2AStreamEventDataResubscribe type.
  • Test Alignment: Corresponding unit tests have been updated to reflect the refined return type of the resubscribeTask method, ensuring type consistency throughout the codebase.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the resubscribeTask API to remove the Message type from its possible return values. The changes are applied consistently across the client, transport layers, and tests. However, there is a critical issue in the type definition for the new return type, which will prevent the code from compiling. I've left a comment with a suggested fix.

@guglielmo-san guglielmo-san requested a review from ishymko December 9, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant