Initial implementation of virtual event stream handler for Connections #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lamparter
force-pushed
the
connections
branch
2 times, most recently
from
49439fb to
ad9e8ce
Compare
- Changed the type of InnerConnections in ModifiableEntity, ModifiableProject, ModifiableProjectRole, ModifiablePublisher, ModifiableUser, and ModifiableUserRole from IModifiableConnectionsCollection to ModifiableConnectionCollection. - Updated methods to use renamed ModifiableConnectionCollection type - Renamed ReadOnlyConnectionsCollection to ReadOnlyConnectionCollection - Refactored Connections property to GetConnectionsAsync. - Updated ModifiableConnection and ModifiableConnectionCollection classes to handle connection add/remove methods, event stream entry updates and class events. - Updated ReadOnlyConnection to implement IDelegable<Connection> and added GetValueAsync method. - Ensured all relevant classes now utilize the newly implemented connection handling implementation. - Modified ModifiableImagesCollection to include an additional parameter for image files in ApplyEntryUpdateAsync methods.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces an initial implementation for a virtual event stream handler related to Connections, converting various connection-related properties to use concrete collection types and asynchronous patterns. Key changes include replacing IReadOnlyConnectionsCollection with ReadOnlyConnectionCollection in entities, adding asynchronous methods for retrieving connections, and updating model definitions from dictionaries to arrays.
Reviewed Changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Nomad/ReadOnlyEntity.cs | Updates InnerConnections type and removes the old Connections property in favor of an async method. |
| src/Nomad/ReadOnlyConnectionCollection.cs | Implements a new read-only connections collection with async support. |
| src/Nomad/ReadOnlyConnection.cs | Adds asynchronous GetValueAsync implementation based on the new connection model. |
| src/Nomad/ModifiableUserRole.cs | Refactors methods to use lambda expressions and introduces async methods for connections. |
| src/Nomad/ModifiablePublisherRole.cs | Updates connection-related methods to use async enumerables. |
| src/Nomad/ModifiablePublisher.cs | Adjusts connection collection usage for publishers. |
| src/Nomad/ModifiableProjectRole.cs | Introduces an async method to fetch connections. |
| src/Nomad/ModifiableProject.cs | Revises the connection collection implementation to use async methods. |
| src/Nomad/ModifiableImagesCollection.cs | Enhances image update methods with an additional parameter and updated event invocations. |
| src/Nomad/ModifiableEntity.cs | Updates InnerConnections type and integrates async connections retrieval and reset. |
| src/Nomad/ModifiableConnectionCollection.cs | New implementation supporting add/remove connection events via async event stream updates. |
| src/Nomad/ModifiableConnection.cs | Adds a new modifiable connection implementation using async updates. |
| src/Nomad/ModifiableAccentColor.cs | Refactors the UpdateAccentColorAsync method while keeping consistent event stream handling. |
| src/Models/User.cs, Publisher.cs, Project.cs | Changes the Connections property from a dictionary to an array for consistency with new connection models. |
| src/Models/IConnections.cs | Revises the IConnections interface to use a Connection[] and adds a new Connection record definition. |
| src/IReadOnlyConnectionsCollection.cs | Modifies the interface to expose an async method for retrieving connections. |
| src/IReadOnlyConnection.cs | Adjusts the interface to expose an asynchronous getter for connection values. |
Arlodotexe
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is incomplete and I had to leave my desk while implementing it.
Feel no need to merge this PR or do anything with the implementation here (which is mostly missing).