Skip to content

Conversation

@314systems
Copy link
Contributor

Summary

  • small bug fix

What does this implement/fix?

  • Test Imports and Annotations:
    • Replaces the kotlin.test.Test import with org.junit.Test in WiFiChannelsParameterizedTest.kt to ensure consistent usage of JUnit annotations in the test suite.
  • Locale Display Method Update:
    • Updates the usage of the locale display country method in WiFiChannelCountryTest.kt to use getDisplayCountry(Locale) for more accurate localization, instead of the deprecated or less specific displayCountry property.

Checklist (required before marking ready)

  • I added or updated unit tests (see app/src/test/)
  • I followed the project's coding style (ktlint) and formatting
  • I ran lint and addressed or documented any warnings
  • CI checks pass (unit tests, coverage, lint)
  • No sensitive data, keys, or secrets are included

Copilot AI review requested due to automatic review settings January 1, 2026 04:12
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses minor consistency and code quality improvements in the test suite. The changes standardize test annotations to use JUnit consistently and improve code readability.

Key changes:

  • Standardizes test annotation imports to use org.junit.Test instead of kotlin.test.Test
  • Updates locale display method call to be explicit with getDisplayCountry(Locale) parameter
  • Simplifies lambda expression by removing redundant explicit parameter declaration

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
WiFiChannelsParameterizedTest.kt Replaces kotlin.test.Test with org.junit.Test to align with JUnit 4 parameterized test framework usage; simplifies lambda by removing redundant it -> syntax
WiFiChannelCountryTest.kt Updates assertion to use explicit getDisplayCountry(expected) call instead of displayCountry property, making the locale parameter explicit and matching the implementation's behavior

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Jan 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.67%. Comparing base (58fda6a) to head (d3e40cd).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #582   +/-   ##
=========================================
  Coverage     97.67%   97.67%           
  Complexity      975      975           
=========================================
  Files           121      121           
  Lines          2579     2579           
  Branches        211      211           
=========================================
  Hits           2519     2519           
  Misses           21       21           
  Partials         39       39           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant