-
Notifications
You must be signed in to change notification settings - Fork 43
feat: Add discount programs scraper and parser with tests #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
feat: Add discount programs scraper and parser with tests #110
Conversation
Removed local replace directive for nebula-api. Checks should work
|
Note: This time checks failed due to the discount schema not existing in the nebula-api base repo yet. (Need PR). As of now the replace line has been removed and you can use the previous commit along with the repo version in the pull request in nebula-api for testing locally before confirming the merge. |
🔄 Status Update@mikehquan19 This PR is ready to merge after nebula-api PR #307. Current Failing Checks - Expected ✅The build is failing because the After PR #307 Merges:
What's Ready Now:
Just waiting on the schema PR to unlock this! Should be quick after that. |
|
@NewdlDewdl the schema PR has been merged so you can go ahead update the go.mod dependency :) Sorry for such a late response, Final was crazy. After that, this should be good to merge and get it up to production. |
No worries, I'll update the go.mod once I have some time. |
Hey Rohin, hope you have a great start of semester (besides the weather). Just a follow up on this. |
Add Discount Programs Scraper
Summary
Implements scraper and parser for UTD Student Government discount programs (https://sg.utdallas.edu/discount/)
Extracts 205 discount programs across 13 categories.
Closes #109
Dependencies
DiscountProgramschema)About
go.modReplace DirectiveThis PR includes a temporary replace directive for local development:
After nebula-api PR merges, remove this line and update:
Changes
New Files
scrapers/discounts.go- Scraper (saves raw HTML)parser/discountsParser.go- Parser (extracts to JSON)parser/discountsParser_test.go- Unit tests (7 functions, 26 test cases)DISCOUNT_SCRAPER.md- DocumentationModified Files
main.go- Added-discountsflaggo.mod- Added replace directiveREADME.md- Updated commandsrunners/weekly.sh- Added to weekly scheduleFeatures
Usage
Testing
Covers: parsing, validation, HTML entities, phone detection, email extraction
Related PRs
DiscountProgramschema (merge first)