Skip to content

Conversation

@iphydf
Copy link
Member

@iphydf iphydf commented Dec 28, 2024

This change is Reviewable

@iphydf iphydf added this to the v1.18.1 milestone Dec 28, 2024
@github-actions github-actions bot added the refactor Refactoring production code, eg. renaming a variable, not affecting semantics label Dec 28, 2024
@codecov
Copy link

codecov bot commented Dec 28, 2024

Codecov Report

Attention: Patch coverage is 37.24490% with 123 lines in your changes missing coverage. Please review.

Project coverage is 11.09%. Comparing base (52d8c6d) to head (6cc296a).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
src/core/core.cpp 50.37% 66 Missing ⚠️
src/core/corefile.cpp 13.95% 37 Missing ⚠️
src/core/conferencetype.cpp 0.00% 9 Missing ⚠️
util/src/toxcoreerrorparser.cpp 0.00% 9 Missing ⚠️
src/core/conferencetype.h 0.00% 1 Missing ⚠️
src/widget/form/conferenceinviteform.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #320      +/-   ##
==========================================
+ Coverage   11.02%   11.09%   +0.07%     
==========================================
  Files         296      299       +3     
  Lines       21442    21541      +99     
==========================================
+ Hits         2365     2391      +26     
- Misses      19077    19150      +73     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iphydf iphydf force-pushed the events branch 7 times, most recently from c518972 to ef157ab Compare January 1, 2025 22:23
@iphydf iphydf modified the milestones: v1.18.1, v1.18.x, v1.18.2 Jan 3, 2025
@iphydf iphydf force-pushed the events branch 2 times, most recently from 97b71f4 to fadfc19 Compare January 7, 2025 22:25
@iphydf iphydf modified the milestones: v1.18.2, v1.18.3 Jan 8, 2025
@iphydf iphydf force-pushed the events branch 6 times, most recently from b8cd385 to 6b13b59 Compare January 13, 2025 23:34
@iphydf iphydf force-pushed the events branch 4 times, most recently from a77a95e to 19bd6ac Compare January 20, 2025 09:45
@iphydf iphydf modified the milestones: v1.18.3, v1.18.x Jan 20, 2025
@github-actions
Copy link

github-actions bot commented Mar 9, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Refactoring production code, eg. renaming a variable, not affecting semantics

Development

Successfully merging this pull request may close these issues.

1 participant