grt: add option to show runtime at the end of global_route execution #9292
Conversation
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a useful feature to report the runtime of the global routing process. The implementation is straightforward and well-integrated with the existing TCL interface and documentation. I have a few suggestions to improve const-correctness and ensure the accuracy of the timing measurements.
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
|
As I commented there ORFS is already using log_cmd to report the time. Having an off by default option doesn't seem that useful. @stefanottili is this what you are asking for and it is still relevant? |
|
a) not everybody is using ORFS, sometimes running a P&R flow in "one script, without getting in/out of the tool" is a good thing. |
GRT is less verbose than DRT, so the |
|
@eder-matheus we suppress runtime related messages in test/helpers.tcl for unit testing to avoid output differences (they occur elsewhere like drt). |
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
3 participants
Partially covers the comments made here: #3536 (comment)
This PR adds the ability to show the runtime of the global_route command. It is only enabled by using the flag -show_runtime. This is off by default for reproducibility purposes (e.g., unit tests that relies on the tool log).