Detected new tests and Opened PR on jinjava project #1150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Contributor
Author
Contributor
|
The log only has 3 runs. Can you try running NonDex with more runs? I tried 10 on the commit you found and got some test failures. |
Contributor
|
|
Contributor
Author
yup. You are right. The test is still flaky. |
Contributor
|
Please just modify this PR. |
NDR0216
changed the title
NDR0216
changed the title
Contributor
Author
I updated this PR |
Contributor
|
Ok to merge @darko-marinov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I detected new flaky tests on jinjava project, and I opened HubSpot/jinjava#1133 to address the problem.