-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Migrate file_operations to use Rust #4431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/4.0
Are you sure you want to change the base?
Migrate file_operations to use Rust #4431
Conversation
6692f98 to
1915417
Compare
99437bb to
fad31ed
Compare
033c280 to
f117234
Compare
f117234 to
d87abf7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 18 out of 19 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
57116a3 to
4566555
Compare
4566555 to
6c892ed
Compare
6c892ed to
9e968fb
Compare
EmmanuelMess
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested
Description
Experimental PR to migrate
file_operationsmodule to write native code in Rust instead of C++.While not important and overhead in set things up, as well as lack of Rust support in Android Studio, enabling use of Rust would open more opportunities of integration with modern libraries.
Quick test for the Rust code:
/apex,/init.rc)Manual tests
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheck