nix flake refactor: avoid with lib; & use lib.optional*
#2813
+16
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream Nixpkgs has been pushing the style of removing ``with lib;`` with the reasoning of clarity around where variables in scope come that hurt readability & static analysis[*]. While on the topic of ``lib``, introduce ``lib.optional`` & ``lib.optionalString`` in a few more places to tidy up the code while using common library patterns. .. [*] https://nix.dev/guides/best-practices#with-scopes Format: text/x-rst
toastal
force-pushed
the
nix-flake-avoid-with-lib
branch
from
742a197 to
0a64bfb
Compare
|
Looks good to me! I tested on my local system as well, to ensure the build succeeded with these changes. |
benjamb
approved these changes
Mar 25, 2025
Contributor
|
Also bump! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream Nixpkgs has been pushing the style of removing
with lib;with the reasoning of clarity around where variables in scope come that hurt readability & static analysis1.While on the topic of
lib, introducelib.optional&lib.optionalStringin a few more places to tidy up the code while using common library patterns.Also has been open @ https://gitlab.com/StevenBlack/hosts/-/merge_requests/2
Footnotes
https://nix.dev/guides/best-practices#with-scopes ↩