Skip to content

Correct directory entry for Milwaukee Makerspace #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
DanDude0 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Correct directory entry for Milwaukee Makerspace #288

DanDude0 wants to merge 1 commit into from
+1 −1

Conversation

@DanDude0
Copy link

@DanDude0 DanDude0 commented May 23, 2025 •
edited by rnestler
Loading

Correct SpaceAPI Entry for Milwaukee Makerspace

If you're adding a new endpoint make sure that

@dbrgn
Copy link
Contributor

dbrgn commented May 23, 2025

Hi, as indicated in the validator (linked in the template you used), the CORS headers for your endpoint are not set properly:

https://validator.spaceapi.io/ui/?url=https://milwaukeemakerspace.org/spaceapi.json

Could you fix that? Otherwise JS based applications cannot access your endpoint.

Otherwise, the endpoint looks good 🙂

@rnestler
Copy link
Member

rnestler commented Jun 16, 2025 •
edited
Loading

@DanDude0 any update on this? https://milwaukeemakerspace.org/spaceapi.json seems currently down is very slow currently btw.

@rnestler
Copy link
Member

rnestler commented Aug 10, 2025

I don't understand it. Somehow on the validator it seems like it is down:
image

But it seems reachable... Any insights?

@rnestler
Copy link
Member

rnestler commented Aug 28, 2025 •
edited
Loading

I guess this is a IPv4 / IPv6 issue? Over IPv4 the server seems to work and respond.

@s3lph
Copy link
Member

s3lph commented Aug 29, 2025

It's not an IPv4 vs IPv6 issue. Even from within the validator container I can query both successfully.

However, what seems to be happening is that the nginx server hosting the endpoint is returning a 403 Forbidden HTML page when the Go-http-client/1.1 user agent is used (which the validator does):

$ curl -v -A 'Go-http-client/1.1' https://milwaukeemakerspace.org/spaceapi.json
> GET /spaceapi.json HTTP/2
> Host: milwaukeemakerspace.org
> User-Agent: Go-http-client/1.1
> Accept: */*
>
< HTTP/2 403
< server: nginx/1.18.0
< date: Fri, 29 Aug 2025 20:18:35 GMT
< content-type: text/html
< content-length: 153
<
<html>
<head><title>403 Forbidden</title></head>
<body>
<center><h1>403 Forbidden</h1></center>
<hr><center>nginx/1.18.0</center>
</body>
</html>

@DanDude0 please make sure any such widespread user-agent blocking is disabled.

@s3lph s3lph mentioned this pull request Oct 10, 2025
Closed
@rnestler
Copy link
Member

rnestler commented Oct 19, 2025

Still does return 403.

@DanDude0 @s3lph
Update directory.json
39b30af 
Correct SpaceAPI Entry for Milwaukee Makerspace
@s3lph
Copy link
Member

s3lph commented Jan 3, 2026

@DanDude0 any chance you can remove this user agent filtering from your SpaceAPI endpoint, so that we can merge this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs-update

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DanDude0 @dbrgn @rnestler @s3lph