fix(get_scm_info): cast error with commits_by_line param

[rishichintala]

Summary
Fixes a bug in get_scm_info where the commits_by_line property is defined as boolean,
causing Boolean cannot be cast to String errors when invoking /api/sources/scm.

Changes

• Changed property type from boolean to string.
• Parse string into Boolean before API call.
• Tested locally against SonarQube Community Edition with and without commits_by_line.

Verification

• "commits_by_line" = "true" → works
• "commits_by_line" = "false" → works
• No param → works

Impact

• Prevents runtime crash.
• Aligns tool with SonarQube Web API contract.

Example:

• "Get SCM info for file components/shared/Spinner.tsx in project code-frontend without per-line commits." The tool fails.

Observed Error

Error executing tool get_scm_info: Tool execution failed:
An error occurred during the tool execution:
class java.lang.Boolean cannot be cast to class java.lang.String
(java.lang.Boolean and java.lang.String are in module java.base of loader 'bootstrap')

Root Cause

• In GetScmInfoTool.java, commits_by_line is defined as a boolean:

.addBooleanProperty(COMMITS_BY_LINE_PROPERTY, ...)

• At runtime it is read with getOptionalBoolean().

• This produces a Boolean, which is incompatible with the expected query string for the API.

[nquinquenel]

Hey @rishichintala, thanks a lot for your contribution!

You’re absolutely right, we shouldn’t fail in this case. I’ve created a reference ticket here: MCP-106.

That said, the fix you proposed doesn’t fully cover the issue and is missing some tests. If you’re okay with it, I’ll handle the changes in a separate PR and also take the opportunity to improve the overall parsing of the tool’s parameters. Of course, I’ll make sure to credit your contribution.

Thanks again!

[rishichintala]

Hello, Thanks for the follow-up! That sounds great. I’m totally fine with you taking it forward. Appreciate you crediting the contribution, and I’m glad it helps improve the overall parsing. Regards, Sai Rishith Chintala

…

On Mon, Sep 8, 2025 at 9:31 AM Nicolas QUINQUENEL ***@***.***> wrote: *nquinquenel* left a comment (SonarSource/sonarqube-mcp-server#85) <#85 (comment)> Hey @rishichintala <https://github.com/rishichintala>, thanks a lot for your contribution! You’re absolutely right, we shouldn’t fail in this case. I’ve created a reference ticket here: MCP-106 <https://sonarsource.atlassian.net/browse/MCP-106>. That said, the fix you proposed doesn’t fully cover the issue and is missing some tests. If you’re okay with it, I’ll handle the changes in a separate PR and also take the opportunity to improve the overall parsing of the tool’s parameters. Of course, I’ll make sure to credit your contribution. Thanks again! — Reply to this email directly, view it on GitHub <#85 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOWFI536EC27MAMG2F3N4ML3RWAJ5AVCNFSM6AAAAACFZ74NQ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTENRWGMZTINJYG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[nquinquenel]

Fixed via #87

Thanks!