SLVS-2742 File System Investigation

[georgii-borovinskikh-sonarsource]

Part of SLVS-2605

[hashicorp-vault-sonar-prod]

SLVS-2742

[sonarqubecloud]

SonarQube reviewer guide

Important

We are currently testing different models for AI Summary.
Please give us your feedback by filling this form.

Model A:

Summary: Adds debug logging with JSON serialization to investigate file system tracking issues; ignores test class.

Review Focus:

• New Newtonsoft.Json dependency added to SLCore.Listeners
• Custom JSON serializer that filters content properties
• Extensive try-catch logging added to production code
• Case-insensitive file path comparisons introduced
• Test class permanently ignored

Start review at: src/Integration/LocalServices/FileTracker.cs. This file contains the core changes including the new JSON serialization logic, error handling, and logging implementation that affects the file tracking subsystem.

Model B:

Summary: Add Newtonsoft.Json dependency and enhance file system debugging with JSON serialization and exception handling in file tracking and listing operations.

Review Focus:

• The new IgnoreContent contract resolver filters out "content" properties during JSON serialization—verify this exclusion is intentional and won't hide critical debugging data
• Exception handling wrapping in NotifySlCoreFilesChanged and ListFilesAsync—ensure exceptions are properly logged without swallowing important failures
• Case-insensitive file path comparisons in RoslynProjectWrapper—confirm this doesn't introduce unintended matches on case-sensitive systems

Start review at: src/Integration/LocalServices/FileTracker.cs. This file contains the core logic changes including the new JSON serialization settings, the contract resolver implementation, and the try-catch wrapping around file change notifications. Understanding these changes is critical as they modify error handling behavior and add a new external dependency (Newtonsoft.Json).

Quality Gate failed

Failed conditions
2 New issues
72.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE