SONARJAVA-4260 add RestAssuredMockMvc assertions to list of test assertions #4951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
sonarqube is raising 1 issue, but for me, it is not relevant for this case and to maintain the consistency with the rest of the code it is better to keep the comment at the end of the line |
| "ruleKey": "S1130", | ||
| "hasTruePositives": true, | ||
| "falseNegatives": 25, | ||
| "falseNegatives": 26, |
Contributor
There was a problem hiding this comment.
Why did this change? S1130 looks unrelated to tests.
java-checks/src/main/java/org/sonar/java/checks/helpers/UnitTestUtils.java
Outdated
Show resolved
Hide resolved
Contributor
tomasz-tylenda-sonarsource
left a comment
tomasz-tylenda-sonarsource
left a comment
There was a problem hiding this comment.
There's some SonarQube issue as well.
Feel free to just reply if everything is fine and I misunderstood something.
tomasz-tylenda-sonarsource
approved these changes
Dec 6, 2024
Contributor
tomasz-tylenda-sonarsource
left a comment
tomasz-tylenda-sonarsource
left a comment
There was a problem hiding this comment.
Discussed in person. LGTM.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SONARJAVA-4260
Part of