-
Notifications
You must be signed in to change notification settings - Fork 0
Configure project to use private artifactory nuget source and package locks #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
bb210a7 to
c5fc43b
Compare
6d03381 to
5b4f2ab
Compare
NuGet.Config
Outdated
|
|
||
| <config> | ||
| <clear /> | ||
| <add key="signatureValidationMode" value="accept" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be set to require?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the Microsoft dotnet packages are preview and not signed, so require would fail. I've used accept instead so that we check the signed packages and not fail for the unsigned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we replace those packages with non-preview versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to have them documented at least
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently the project uses a preview version of the dotnet 6 to build, with the following comment
.WithProperty("RuntimeFrameworkVersion", "6.0.0-preview.7.21317.1") // Set the minimum runtime to a .NET 6 prerelease so that prerelease SDKs will be considered during rollForward.
I could change it to eg. 6.0.36, so it doesn't use preview packages and everything is signed. But I don't know the implications of this change.
2c0d659 to
51c8a5c
Compare
51c8a5c to
d5ed718
Compare
d5ed718 to
67f5b45
Compare
|
ce54c6d to
5376551
Compare





No description provided.