Skip to content

Conversation

@vnaskos-sonar
Copy link

No description provided.

@vnaskos-sonar vnaskos-sonar force-pushed the vn/use-artifactory branch 6 times, most recently from 6d03381 to 5b4f2ab Compare December 5, 2025 07:59
@vnaskos-sonar vnaskos-sonar changed the title Configure project to use private artifactory nuget source Configure project to use private artifactory nuget source and package locks Dec 5, 2025
@vnaskos-sonar vnaskos-sonar marked this pull request as ready for review December 5, 2025 08:20
NuGet.Config Outdated

<config>
<clear />
<add key="signatureValidationMode" value="accept" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be set to require?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the Microsoft dotnet packages are preview and not signed, so require would fail. I've used accept instead so that we check the signed packages and not fail for the unsigned.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we replace those packages with non-preview versions?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have them documented at least

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently the project uses a preview version of the dotnet 6 to build, with the following comment

.WithProperty("RuntimeFrameworkVersion", "6.0.0-preview.7.21317.1") // Set the minimum runtime to a .NET 6 prerelease so that prerelease SDKs will be considered during rollForward.

I could change it to eg. 6.0.36, so it doesn't use preview packages and everything is signed. But I don't know the implications of this change.

@vnaskos-sonar vnaskos-sonar force-pushed the vn/use-artifactory branch 2 times, most recently from 2c0d659 to 51c8a5c Compare December 5, 2025 10:59
@sonarqube-next
Copy link

sonarqube-next bot commented Dec 5, 2025

Quality Gate passed Quality Gate passed for 'omnisharp-roslyn'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants