Skip to content

ZJIT: Optimize NewArray to use rb_ec_ary_new_from_values #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
goshanraj-g wants to merge 2 commits into from
Closed

ZJIT: Optimize NewArray to use rb_ec_ary_new_from_values #899

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
352c9b6
ZJIT: Optimize NewArray to use rb_ec_ary_new_from_values (fixes #829)
goshanraj-g Nov 29, 2025
3e9dd93
fix: use leaf calls for NewArray instead of non-leaf calls
goshanraj-g Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions zjit/src/codegen.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1411,15 +1411,16 @@ fn gen_new_array(
) -> lir::Opnd {
gen_prepare_leaf_call_with_gc(asm, state);

let length: c_long = elements.len().try_into().expect("Unable to fit length of elements into c_long");
let num: c_long = elements.len().try_into().expect("Unable to fit length of elements into c_long");

let new_array = asm_ccall!(asm, rb_ary_new_capa, length.into());

for val in elements {
asm_ccall!(asm, rb_ary_push, new_array, val);
if elements.is_empty() {
asm_ccall!(asm, rb_ec_ary_new_from_values, EC, 0i64.into(), Opnd::UImm(0))
} else {
let argv = gen_push_opnds(asm, &elements);
let new_array = asm_ccall!(asm, rb_ec_ary_new_from_values, EC, num.into(), argv);
gen_pop_opnds(asm, &elements);
new_array
}

new_array
}

/// Compile array access (`array[index]`)
Expand Down
Loading