ZJIT: Optimize NewArray to use rb_ec_ary_new_from_values #896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekknolagi
reviewed
Dec 3, 2025
| gen_prepare_leaf_call_with_gc(asm, state); | ||
|
|
||
| let length: c_long = elements.len().try_into().expect("Unable to fit length of elements into c_long"); | ||
| gen_prepare_non_leaf_call(jit, asm, state); |
Author
There was a problem hiding this comment.
Sorry about that! I'll change it to a leaf call (gen_prepare_leaf_call_with_gc). I was referencing the hash insertion functions which were similar and utilized non-leaf calls. Now, the updated code uses leaf calls (submitted a PR to ruby/ruby)
tekknolagi
changed the title
|
FYI you should make a PR against ruby/ruby instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #829
Instead of calling
rb_ary_new_capaandrb_ary_pushfor each element (this is N+1 C function calls), this usesgen_push_opndsand callsrb_ec_ary_new_from_valuesonce, which matches what the interpreter and YJIT do