Prevent rake compiler from defining application defined task: #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Gem that define a Rake Compiler task (pretty much all) interfere with our own. The reason we can't rely on the user defined task is because it's not configured for compiling fat gems, it is usually only configured to compile natively for development purposes. I also would like the configuration of cibuildgem to not interfere with the gem defined task and not have to ask maintainers to change basic configuration just to make compiling fat gems possible, cibuildgem should take care of this automatically. For reference, I originally decided to choose running the whole compilation dance in a subprocess and require the gem Rakefile because I felt this would be the right entrypoint to configure CIbuildgem if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gem that define a Rake Compiler task (pretty much all) interfere with our own. The reason we can't rely on the user defined task is because it's not configured for compiling fat gems, it is usually only configured to compile natively for development purposes.
I also would like the configuration of cibuildgem to not interfere with the gem defined task and not have to ask maintainers to change basic configuration just to make compiling fat gems possible, cibuildgem should take care of this automatically.
For reference, I originally decided to choose running the whole compilation dance in a subprocess and require the gem Rakefile because I felt this would be the right entrypoint to configure CIbuildgem if needed.