visit counter endpoint + model, display on homepage #1985
Conversation
|
add a screenshot!! |
on bottom right of the home page |
|
looks good, make sure you fix lint errors, you can run |
| { | ||
| visitCount: { | ||
| type: Number, | ||
| default: 0 | ||
| } | ||
| }, |
There was a problem hiding this comment.
can we add one more field, its called type, and it can be an enum like ['HOME_PAGE'] for now
we can then add more stuff to this schema later if we want to track visits to other pages
| const router = express.Router(); | ||
| const visitCounter = require('../models/HomepageVisit'); | ||
| const { FORBIDDEN, BAD_REQUEST, OK } = require('../../util/constants').STATUS_CODES; | ||
| const allowedOrigin = 'https://sce.sjsu.edu'; |
There was a problem hiding this comment.
what about if its in dev mode? could we only check if we are in prod?
like if (process.env.NODE_ENV === 'production')
also lets name this variable SCE_SJSU_EDU
| export async function getVisitCount() { | ||
| let status = new ApiResponse(); | ||
| try { | ||
| const res = await fetch (BASE_API_URL + 'api/Homepage/count'); |
There was a problem hiding this comment.
please create and use the url class like below
Clark/src/APIFunctions/User.js
Line 107 in 33fc137
| export async function incrementVisitCount() { | ||
| let status = new ApiResponse(); | ||
| try { | ||
| await fetch (BASE_API_URL + 'api/Homepage/visit', { |
There was a problem hiding this comment.
see other comment about url class
3 participants
for issue #1952