Skip to content

Conversation

@sungbinoh
Copy link
Contributor

@sungbinoh sungbinoh commented Oct 17, 2025

…s of true particles from nu-int

Description

Please provide a detailed description of the changes this pull request introduces. If available, also link to a docdb link where the issue/change have been presented on/discussed.

  • Have you added a label? (bug/enhancement/physics etc.)
  • Have you assigned at least 1 reviewer?
  • Is this PR related to an open issue / project?
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer as additional reviewer.
  • Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)? If so, please link it in the description.
  • Are you submitting this PR on behalf of someone else who made the code changes? If so, please mention them in the description.

This is exactly the same updates with PR591 but into the develop.

@sungbinoh sungbinoh requested a review from jzennamo October 17, 2025 17:25
@sungbinoh sungbinoh self-assigned this Oct 17, 2025
@sungbinoh sungbinoh added the bugfix Addresses one or more bugs label Oct 17, 2025
@sungbinoh sungbinoh changed the title adding an if condition for fixing exactly same start and end position… Bug fix for the exactly the same start and end positions for particles from neutrino interactions in AV Oct 17, 2025
@sungbinoh sungbinoh changed the title Bug fix for the exactly the same start and end positions for particles from neutrino interactions in AV Bug fix for the exactly the same start and end positions for particles from neutrino interactions in AV - To develop Oct 17, 2025
@linyan-w linyan-w moved this to Expected for validation II in SBND 2025 Fall Production Oct 27, 2025
@linyan-w linyan-w moved this from Expected for validation II to Waiting on Reviewer in SBND 2025 Fall Production Nov 3, 2025
@kjplows kjplows moved this to Open pull requests in SBN software development Nov 4, 2025
@linyan-w
Copy link
Contributor

Given #591 has been merged w/o issue, I suggest we merge into the develop w/o waiting for Joseph (he reviewed the production ver of this already.).

@linyan-w linyan-w moved this from Waiting on Reviewer to Expected for validation II MC in SBND 2025 Fall Production Nov 19, 2025
@nathanielerowe nathanielerowe moved this from Expected for validation II MC to Reviewer Approved in SBND 2025 Fall Production Nov 20, 2025
@kjplows kjplows moved this from Open pull requests to Testing in SBN software development Nov 20, 2025
@kjplows kjplows moved this from Reviewer Approved to Ready for CI in SBND 2025 Fall Production Nov 20, 2025
@kjplows
Copy link
Contributor

kjplows commented Nov 20, 2025

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_12_02

@kjplows kjplows moved this from Testing to Urgent checks in SBN software development Nov 20, 2025
@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@kjplows kjplows moved this from Ready for CI to RM Approved in SBND 2025 Fall Production Nov 20, 2025
@kjplows kjplows moved this from Urgent checks to To merge in SBN software development Nov 20, 2025
@kjplows kjplows merged commit ad302ca into SBNSoftware:develop Nov 21, 2025
@github-project-automation github-project-automation bot moved this from To merge to Done in SBN software development Nov 21, 2025
@kjplows kjplows moved this from Done to Recently done in SBN software development Nov 21, 2025
@nathanielerowe nathanielerowe moved this from RM Approved to In tagged release in SBND 2025 Fall Production Nov 22, 2025
@kjplows kjplows moved this from Recently done to Done in SBN software development Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Addresses one or more bugs

Projects

Status: Done
Status: In tagged release

Development

Successfully merging this pull request may close these issues.

True particles from neutrino interactions often have exactly the same start and end positions

5 participants