Check Downloaded and Drag & Dropped Mods for Targetted Game and Warn If None #769

TheBestAstroNOT · 2025-12-10T19:14:10Z

No description provided.

…ere no compatible applications are found

TheBestAstroNOT · 2025-12-10T19:16:02Z

Only works for drag and dropping right now, working on support for mods installed via the R2 protocol (it isn't going well)

TheBestAstroNOT · 2025-12-10T19:40:12Z

PR for #751

TheBestAstroNOT · 2025-12-10T19:40:46Z

I also made these two mods to test it https://github.com/TheBestAstroNOT/psychic-happiness/releases/tag/1.0.0

TheBestAstroNOT · 2025-12-11T11:57:24Z

@dreamsyntax are there any changes you would like to see?

dreamsyntax · 2025-12-11T21:06:24Z

Ok, now I've properly tested this build.

Drag & Drop

"No" instead of "Cancel" makes more sense, since the mod itself still gets installed, we just don't set the supported app.

Ideally there would be three options
"No" -> no edit, but keeps the mod installed
"Yes" -> edit screen
"Abort/Cancel" -> does not install the mod at all

Since this happens after a download for example though, I think its fine to just change it to
"No" and "Yes" to be more clear that the mod will still be installed.

--

Mod Loader Download Button

Does not seem to invoke this flow at all

R2 Links (Gamebanana)

Invokes flow successfully

…S/NO

TheBestAstroNOT · 2025-12-12T16:40:22Z

@dreamsyntax Can you test the mod loader's one click download button again, I'd do it myself but I don't know of any mods that I can test with.

dreamsyntax · 2025-12-12T16:44:17Z

@dreamsyntax Can you test the mod loader's one click download button again, I'd do it myself but I don't know of any mods that I can test with.

I'll try later today.

If you want to test in interim:

If you add any exe renamed as tsonic_win.exe, it will add Sonic Heroes as a gamebanana source. You'll be able to see 64 Mario skin for that game in the download manager, which has the issue.

dreamsyntax · 2025-12-12T16:44:18Z

@dreamsyntax Can you test the mod loader's one click download button again, I'd do it myself but I don't know of any mods that I can test with.

I'll try later today.

If you want to test in interim:

If you add any exe renamed as tsonic_win.exe, it will add Sonic Heroes as a gamebanana source. You'll be able to see 64 Mario skin for that game in the download manager, which has the issue.

TheBestAstroNOT · 2025-12-12T17:13:18Z

Ok it seems to be working

dreamsyntax · 2025-12-12T20:04:17Z

source/Reloaded.Mod.Launcher/Pages/Dialogs/XamlResourceMessageBoxOkCancel.xaml.cs

-    public XamlResourceMessageBoxOkCancel(string titleResourceName, string descriptionResourceName, string okButtonTextResourceName, string cancelButtonTextResourceName) : base(new XamlResource<string>(titleResourceName).Get(), new XamlResource<string>(descriptionResourceName).Get())
+    public XamlResourceMessageBoxOkCancel(string title, string message, string okText, string cancelText) : base(title, message)
    {
-        this.CancelBtn.Content = Lib.Static.Resources.ResourceProvider.Get<string>(cancelButtonTextResourceName);
-        this.OKBtn.Content = Lib.Static.Resources.ResourceProvider.Get<string>(okButtonTextResourceName);


Unless I'm missing something, wouldn't this replace every instance of Ok/Cancel to Yes/No?

Uhh no? You are passing the text every time you call it. Plus other message boxes use another delegate to display their text. Only I'm using this one.

dreamsyntax · 2025-12-12T20:05:05Z

Tested.

Feature works as expected now.

@Sewer56 on any objections with the code?

I left a comment about the resource, the rest looks fine.

TheBestAstroNOT · 2026-01-03T16:05:14Z

Bump

Sewer56 · 2026-01-04T00:50:28Z

Looks reasonable to me. Just doing all sorts of different things as always :p

Copilot

Pull request overview

This PR adds validation logic to warn users when they install mods (via drag & drop or download) that don't have any supported applications configured, or when no compatible installed application exists for the mod. When such a situation is detected, users are prompted to manually select a supported application.

Changes:

Modified XamlResourceMessageBoxOkCancel to add a constructor overload that accepts pre-resolved text strings instead of resource keys
Added validation logic in three installation paths (drag & drop, URL download, and package download) to check for app compatibility
Added localization strings for warning messages and Yes/No button labels
Refactored EditModDialogViewModel to support initialization with collection parameters

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
XamlResourceMessageBoxOkCancel.xaml.cs	Added constructor overload accepting resolved strings for title, message, and button texts
MainWindow.xaml.cs	Added validation logic for drag-and-dropped mods to check app compatibility
en-GB.xaml	Added localization strings for app compatibility warnings and Yes/No buttons
Resources.cs	Added static resource properties for new localization strings
Startup.cs	Added validation logic for downloaded mods to check app compatibility
DownloadPackagesViewModel.cs	Added validation logic for package downloads to check app compatibility
EditModDialogViewModel.cs	Added constructor overload accepting ObservableCollection parameters for flexibility

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-18T15:17:08Z

source/Reloaded.Mod.Launcher/MainWindow.xaml.cs

+                if(item.Value.Config.IsUniversalMod || item.Value.Config.SupportedAppId.Length > 0)
+                {
+                    var match = Lib.IoC.Get<ApplicationConfigService>().Items.FirstOrDefault(app => item.Value.Config.SupportedAppId.Contains(app.Config.AppId));
+                    if(match == null)
+                    {
+                        bool loadAppPage = Actions.DisplayResourceMessageBoxOkCancel!.Invoke(NoCompatibleAppsInConfigTitle.Get(), $"{NoCompatibleAppsInConfigDescription.Get()}\n{AppSelectionQuestion.Get()}", Yes.Get(), No.Get());
+                        if (loadAppPage)
+                        {
+                            var createModDialog = new EditModDialog(new EditModDialogViewModel(item.Value, Lib.IoC.Get<ApplicationConfigService>(), modConfigService));
+                            createModDialog.Owner = System.Windows.Window.GetWindow(this);
+                            createModDialog.RealViewModel.Page = EditModPage.Special;
+                            createModDialog.ShowDialog();
+                        }
+                    }
+                }


The logic appears incorrect. When a mod has IsUniversalMod set to true, it means the mod is compatible with all applications, so there's no need to check for a matching installed app or warn the user. The condition should be checking only if SupportedAppId.Length > 0 (mod has specific supported apps), and then check if a matching installed app exists. Universal mods should not trigger this warning path at all.

ngl it's got a good point

Copilot · 2026-01-18T15:17:08Z

source/Reloaded.Mod.Launcher.Lib/Startup.cs

+                if (item.Value.Config.IsUniversalMod || item.Value.Config.SupportedAppId.Length > 0)
+                {
+                    var match = IoC.Get<ApplicationConfigService>().Items.FirstOrDefault(app => item.Value.Config.SupportedAppId.Contains(app.Config.AppId));
+                    if (match == null)
+                    {
+                        bool loadAppPage = Actions.DisplayResourceMessageBoxOkCancel(Resources.NoCompatibleAppsInConfigTitle.Get(), $"{Resources.NoCompatibleAppsInConfigDescription.Get()}\n{Resources.AppSelectionQuestion.Get()}", Resources.Yes.Get(), Resources.No.Get());
+                        if (loadAppPage)
+                        {
+                            var viewmodel = new EditModDialogViewModel(item.Value, allApps, items);
+                            viewmodel.Page = EditModPage.Special;
+                            var createModDialog = Actions.EditModDialog(viewmodel, null);
+                        }
+                    }
+                }


The logic appears incorrect. When a mod has IsUniversalMod set to true, it means the mod is compatible with all applications, so there's no need to check for a matching installed app or warn the user. The condition should be checking only if SupportedAppId.Length > 0 (mod has specific supported apps), and then check if a matching installed app exists. Universal mods should not trigger this warning path at all.

Copilot · 2026-01-18T15:17:08Z

source/Reloaded.Mod.Launcher.Lib/Models/ViewModel/DownloadPackagesViewModel.cs

+                    if (item.Value.Config.IsUniversalMod || item.Value.Config.SupportedAppId.Length > 0)
+                    {
+                        var match = IoC.Get<ApplicationConfigService>().Items.FirstOrDefault(app => item.Value.Config.SupportedAppId.Contains(app.Config.AppId));
+                        if (match == null)
+                        {
+                            bool loadAppPage = Actions.DisplayResourceMessageBoxOkCancel!.Invoke(Resources.NoCompatibleAppsInConfigTitle.Get(), $"{Resources.NoCompatibleAppsInConfigDescription.Get()}\n{Resources.AppSelectionQuestion.Get()}", Resources.Yes.Get(), Resources.No.Get());
+                            if (loadAppPage)
+                            {
+                                var viewmodel = new EditModDialogViewModel(item.Value, IoC.Get<ApplicationConfigService>(), modConfigService);
+                                viewmodel.Page = EditModPage.Special;
+                                var createModDialog = Actions.EditModDialog(viewmodel, null);
+                            }
+                        }
+                    }


The logic appears incorrect. When a mod has IsUniversalMod set to true, it means the mod is compatible with all applications, so there's no need to check for a matching installed app or warn the user. The condition should be checking only if SupportedAppId.Length > 0 (mod has specific supported apps), and then check if a matching installed app exists. Universal mods should not trigger this warning path at all.

Copilot · 2026-01-18T15:17:09Z

source/Reloaded.Mod.Launcher/MainWindow.xaml.cs

+                if(item.Value.Config.IsUniversalMod || item.Value.Config.SupportedAppId.Length > 0)
+                {
+                    var match = Lib.IoC.Get<ApplicationConfigService>().Items.FirstOrDefault(app => item.Value.Config.SupportedAppId.Contains(app.Config.AppId));
+                    if(match == null)
+                    {
+                        bool loadAppPage = Actions.DisplayResourceMessageBoxOkCancel!.Invoke(NoCompatibleAppsInConfigTitle.Get(), $"{NoCompatibleAppsInConfigDescription.Get()}\n{AppSelectionQuestion.Get()}", Yes.Get(), No.Get());
+                        if (loadAppPage)
+                        {
+                            var createModDialog = new EditModDialog(new EditModDialogViewModel(item.Value, Lib.IoC.Get<ApplicationConfigService>(), modConfigService));
+                            createModDialog.Owner = System.Windows.Window.GetWindow(this);
+                            createModDialog.RealViewModel.Page = EditModPage.Special;
+                            createModDialog.ShowDialog();
+                        }
+                    }
+                }
+                else
+                {
+                    bool loadAppPage = Actions.DisplayResourceMessageBoxOkCancel!.Invoke(NoAppsInConfigTitle.Get(), $"{NoAppsInConfigDescription.Get()}\n{AppSelectionQuestion.Get()}" , Yes.Get(), No.Get());
+                    if (loadAppPage)
+                    {
+                        var createModDialog = new EditModDialog(new EditModDialogViewModel(item.Value, Lib.IoC.Get<ApplicationConfigService>(), modConfigService));
+                        createModDialog.Owner = System.Windows.Window.GetWindow(this);
+                        createModDialog.RealViewModel.Page = EditModPage.Special;
+                        createModDialog.ShowDialog();
+                    }
+                }
+            }


This validation logic is duplicated across three different files (MainWindow.xaml.cs, Startup.cs, and DownloadPackagesViewModel.cs). Consider extracting this logic into a shared helper method to improve maintainability and ensure consistent behavior across all mod installation paths.

Copilot · 2026-01-18T15:17:09Z

source/Reloaded.Mod.Launcher.Lib/Models/ViewModel/DownloadPackagesViewModel.cs

+            foreach (var item in modConfigService.ItemsById.ToArray())
+            {
+                if (!modsBefore.ContainsKey(item.Key))
+                {
+                    newConfigs.Add(item.Value.Config);
+                    if (item.Value.Config.IsUniversalMod || item.Value.Config.SupportedAppId.Length > 0)
+                    {
+                        var match = IoC.Get<ApplicationConfigService>().Items.FirstOrDefault(app => item.Value.Config.SupportedAppId.Contains(app.Config.AppId));
+                        if (match == null)
+                        {
+                            bool loadAppPage = Actions.DisplayResourceMessageBoxOkCancel!.Invoke(Resources.NoCompatibleAppsInConfigTitle.Get(), $"{Resources.NoCompatibleAppsInConfigDescription.Get()}\n{Resources.AppSelectionQuestion.Get()}", Resources.Yes.Get(), Resources.No.Get());
+                            if (loadAppPage)
+                            {
+                                var viewmodel = new EditModDialogViewModel(item.Value, IoC.Get<ApplicationConfigService>(), modConfigService);
+                                viewmodel.Page = EditModPage.Special;
+                                var createModDialog = Actions.EditModDialog(viewmodel, null);
+                            }
+                        }
+                    }
+                    else
+                    {
+                        bool loadAppPage = Actions.DisplayResourceMessageBoxOkCancel!.Invoke(Resources.NoAppsInConfigTitle.Get(), $"{Resources.NoAppsInConfigDescription.Get()}\n{Resources.AppSelectionQuestion.Get()}", Resources.Yes.Get(), Resources.No.Get());
+                        if (loadAppPage)
+                        {
+                            var viewmodel = new EditModDialogViewModel(item.Value, IoC.Get<ApplicationConfigService>(), modConfigService);
+                            viewmodel.Page = EditModPage.Special;
+                            var createModDialog = Actions.EditModDialog(viewmodel, null);
+                        }
+                    }
+                }
+            }


This foreach loop implicitly filters its target sequence - consider filtering the sequence explicitly using '.Where(...)'.

Copilot · 2026-01-18T15:17:09Z

source/Reloaded.Mod.Launcher.Lib/Models/ViewModel/DownloadPackagesViewModel.cs

+            var newConfigs = new List<ModConfig>();
+            foreach (var item in modConfigService.ItemsById.ToArray())
+            {
+                if (!modsBefore.ContainsKey(item.Key))
+                {
+                    newConfigs.Add(item.Value.Config);


The contents of this container are never accessed.

Suggested change

var newConfigs = new List<ModConfig>();

foreach (var item in modConfigService.ItemsById.ToArray())

{

if (!modsBefore.ContainsKey(item.Key))

{

newConfigs.Add(item.Value.Config);

foreach (var item in modConfigService.ItemsById.ToArray())

{

if (!modsBefore.ContainsKey(item.Key))

{

Copilot · 2026-01-18T15:17:09Z

source/Reloaded.Mod.Launcher.Lib/Models/ViewModel/DownloadPackagesViewModel.cs

+                            {
+                                var viewmodel = new EditModDialogViewModel(item.Value, IoC.Get<ApplicationConfigService>(), modConfigService);
+                                viewmodel.Page = EditModPage.Special;
+                                var createModDialog = Actions.EditModDialog(viewmodel, null);


This assignment to createModDialog is useless, since its value is never read.

Copilot · 2026-01-18T15:17:10Z

source/Reloaded.Mod.Launcher.Lib/Models/ViewModel/DownloadPackagesViewModel.cs

+                        {
+                            var viewmodel = new EditModDialogViewModel(item.Value, IoC.Get<ApplicationConfigService>(), modConfigService);
+                            viewmodel.Page = EditModPage.Special;
+                            var createModDialog = Actions.EditModDialog(viewmodel, null);


This assignment to createModDialog is useless, since its value is never read.

Copilot · 2026-01-18T15:17:10Z

source/Reloaded.Mod.Launcher.Lib/Startup.cs

+                        {
+                            var viewmodel = new EditModDialogViewModel(item.Value, allApps, items);
+                            viewmodel.Page = EditModPage.Special;
+                            var createModDialog = Actions.EditModDialog(viewmodel, null);


This assignment to createModDialog is useless, since its value is never read.

Copilot · 2026-01-18T15:17:10Z

source/Reloaded.Mod.Launcher.Lib/Startup.cs

+                    {
+                        var viewmodel = new EditModDialogViewModel(item.Value, allApps, items);
+                        viewmodel.Page = EditModPage.Special;
+                        var createModDialog = Actions.EditModDialog(viewmodel, null);


This assignment to createModDialog is useless, since its value is never read.

Prompt user to select supported applications for a mod in the case wh…

4c87269

…ere no compatible applications are found

TheBestAstroNOT changed the title ~~Prompt user to select supported applications for a mod in the case wh…~~ Check Downloaded and Drag & Dropped Mods for Targetted Game and Warn If None Dec 10, 2025

Web downloads most likely work now

7f88eee

TheBestAstroNOT marked this pull request as ready for review December 10, 2025 19:39

Update Resources.cs

76864cc

TheBestAstroNOT added 2 commits December 12, 2025 22:06

Mod manager downloads probably work now, also changed OK/CANCEL to YE…

6930137

…S/NO

Merge branch 'master' of https://github.com/TheBestAstroNOT/Reloaded-II

93dea82

Merge branch 'Reloaded-Project:master' into master

5e177ac

dreamsyntax reviewed Dec 12, 2025

View reviewed changes

TheBestAstroNOT added 2 commits December 17, 2025 09:34

Merge branch 'master' into master

7fab29d

Update Resources.cs

5249e8f

Refactor EditModDialogViewModel constructor usage

64947d6

Copilot AI review requested due to automatic review settings January 18, 2026 15:13

Copilot started reviewing on behalf of TheBestAstroNOT January 18, 2026 15:13 View session

Copilot AI reviewed Jan 18, 2026

View reviewed changes

TheBestAstroNOT and others added 2 commits January 18, 2026 21:20

Fix incorrect universal config check

de781ef

Merge branch 'master' into master

c41c61b

Uh oh!

Check Downloaded and Drag & Dropped Mods for Targetted Game and Warn If None #769

Are you sure you want to change the base?

Check Downloaded and Drag & Dropped Mods for Targetted Game and Warn If None #769

Uh oh!

Conversation

TheBestAstroNOT commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TheBestAstroNOT commented Dec 10, 2025

Uh oh!

TheBestAstroNOT commented Dec 10, 2025

Uh oh!

TheBestAstroNOT commented Dec 10, 2025

Uh oh!

TheBestAstroNOT commented Dec 11, 2025

Uh oh!

dreamsyntax commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TheBestAstroNOT commented Dec 12, 2025

Uh oh!

dreamsyntax commented Dec 12, 2025

Uh oh!

dreamsyntax commented Dec 12, 2025

Uh oh!

TheBestAstroNOT commented Dec 12, 2025

Uh oh!

dreamsyntax Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

TheBestAstroNOT Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

dreamsyntax commented Dec 12, 2025

Uh oh!

TheBestAstroNOT commented Jan 3, 2026

Uh oh!

Sewer56 commented Jan 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 18, 2026

Choose a reason for hiding this comment

Uh oh!

Sewer56 Jan 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 18, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

TheBestAstroNOT commented Dec 10, 2025 •

edited

Loading

dreamsyntax commented Dec 11, 2025 •

edited

Loading