Fix ASAN errors and FORMAT specifiers #1179
Merged
+215
−210
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the error tests of tall-skinny QR routines, the array
TAUwas of lengthNMAX=2, but theGEMLQandGEMQRroutines read the second and third entry. This was already fixed by a149100 for the real routines. The complex routines still had this issue, and it was flagged by an address sanitizer.I increased the size of
TAUto5since that is the expected minimal size of the array according to the documentation:It doesn't need to be larger, since we never reach the part of the code that reads or writes the rest of the array. Additionally, I removed the unused array
Tin these tests.There were also some FORMAT specifier lines longer than 72 characters in the BLAS tests, which the NAG Fortran compiler doesn't like by default. Those are also fixed now.