Fix infinite loop when text contains multiple unclosed comments #1579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btucker
force-pushed
the
fix/double-comment-bug
branch
from
6ab1ab3 to
e6cabdc
Compare
The updatepos() override was resetting the parser position to 0, causing infinite loops when multiple bogus/unclosed comments appeared in the input (e.g., `</` or `<!--` followed by non-standard characters). Now tracks the position of the triggering `<` and advances past it instead of rewinding to the start of the buffer. Fixes Python-Markdown#1578
btucker
force-pushed
the
fix/double-comment-bug
branch
from
e6cabdc to
94aafb7
Compare
Collaborator
|
Good catch! One question though, I'm not following how this fixed this case: markdown.markdown("`</` and `</`")It seems the reset logic is only triggered when hitting |
Collaborator
|
Never mind, it's |
facelessuser
approved these changes
Dec 28, 2025
Collaborator
facelessuser
left a comment
facelessuser
left a comment
There was a problem hiding this comment.
LGTM. Changelog should get updated, though.
Author
|
Yeah, exactly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The updatepos() override was resetting the parser position to 0, causing infinite loops when multiple bogus/unclosed comments appeared in the input (e.g.,
</followed by non-standard characters or<!--). Now tracks the position of the triggering<and advances past it instead of rewinding to the start of the buffer.Fixes #1578