Skip to content

Conversation

@lshaowei18
Copy link
Contributor

Problem

When creating a survey, there is no visual feedback when the saving fails because the survey name is empty:

Screen.Recording.2025-12-07.at.9.47.40.AM.mov

Changes

Screen.Recording.2025-12-07.at.9.44.38.AM.mov

How did you test this code?

  1. Go to survey creation and choose start from scratch with a blank survey
  2. Click on save as draft
  3. You should see the error Please enter a name

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Changelog: (features only) Is this feature complete?

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@adboio
Copy link
Contributor

adboio commented Dec 7, 2025

i literally just tried to save a survey with no name ~60 seconds ago, came to github to create an issue, and here's your PR!!

amazing timing, thank you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants