Skip to content

feat(web-analytics): show 'Show more' button by default #42881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lricoy merged 3 commits into from
Dec 10, 2025
+6 −4
Merged

feat(web-analytics): show 'Show more' button by default #42881

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
10abd36
feat(web-analytics): show 'Show more' button by default
lricoy Dec 5, 2025
df432ae
Merge branch 'master' into lricoy/web-analytics-show-more-default
lricoy Dec 9, 2025
5d868be
Merge branch 'master' into lricoy/web-analytics-show-more-default
lricoy Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions frontend/src/scenes/web-analytics/WebAnalyticsDashboard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ const QueryTileItem = ({ tile }: { tile: QueryTile }): JSX.Element => {
Open as new insight
</LemonButton>
) : null,
tile.canOpenModal ? (
tile.canOpenModal !== false ? (
<LemonButton
key="open-modal-button"
onClick={() => openModal(tile.tileId)}
Expand Down Expand Up @@ -307,7 +307,7 @@ export const WebTabs = ({
Open as new Insight
</LemonButton>
) : null,
activeTab?.canOpenModal ? (
activeTab?.canOpenModal !== false ? (
<LemonButton
key="open-modal-button"
onClick={() => openModal(tileId, activeTabId)}
Expand Down
6 changes: 4 additions & 2 deletions frontend/src/scenes/web-analytics/webAnalyticsLogic.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1038,6 +1038,7 @@ export const webAnalyticsLogic = kea<webAnalyticsLogicType>([
showIntervalSelect: true,
insightProps: createInsightProps(TileId.GRAPHS, id),
canOpenInsight: !!featureFlags[FEATURE_FLAGS.WEB_ANALYTICS_OPEN_AS_INSIGHT],
canOpenModal: true,
})

const createTableTab = (
Expand Down Expand Up @@ -1096,7 +1097,7 @@ export const webAnalyticsLogic = kea<webAnalyticsLogicType>([
hideTooltipOnScroll: true,
},
canOpenInsight: !!featureFlags[FEATURE_FLAGS.WEB_ANALYTICS_OPEN_AS_INSIGHT],
canOpenModal: false,
canOpenModal: true,
}
}

Expand Down Expand Up @@ -1124,7 +1125,7 @@ export const webAnalyticsLogic = kea<webAnalyticsLogicType>([
columns,
},
canOpenInsight: !!featureFlags[FEATURE_FLAGS.WEB_ANALYTICS_OPEN_AS_INSIGHT],
canOpenModal: false,
canOpenModal: true,
}
}

Expand Down Expand Up @@ -1240,6 +1241,7 @@ export const webAnalyticsLogic = kea<webAnalyticsLogicType>([
},
insightProps: createInsightProps(TileId.OVERVIEW),
canOpenInsight: !!featureFlags[FEATURE_FLAGS.WEB_ANALYTICS_OPEN_AS_INSIGHT],
canOpenModal: false,
},
{
kind: 'tabs',
Expand Down
Loading