Feature/nd/dps310 driver #35
Conversation
Ian-Carroll
requested review from
Akashf,
Burke-Daniel,
colton-smith and
exastone
Burke-Daniel
left a comment
Burke-Daniel
left a comment
There was a problem hiding this comment.
Couple things for you to look at, I'll take another look once you go through and note the functions that you modified. Good job!!
Examples/Blink/cmake.sh
Outdated
| [ -d "build" ] && echo "Build folder already exists!" && cd build | ||
| [ ! -d "build" ] && echo "Build folder does not exist. Creating now." && mkdir build && cd build | ||
|
|
||
| cmake -DCMAKE_TOOLCHAIN_FILE=../arm-none-eabi-gcc.cmake -DCMAKE_BUILD_TYPE=Debug .. |
There was a problem hiding this comment.
Just for learning purposes, do you wanna add in passing a command line parameter to specify building in either Debug or Release configuration?
There was a problem hiding this comment.
@Burke-Daniel New shell script is up from new commits!
| @@ -0,0 +1,771 @@ | |||
| #include "Peripherals/Inc/DPS310.h" | |||
There was a problem hiding this comment.
@Ian-Carroll do you wanna just comb through this and comment the functions that you changed? I only wanna review the stuff that you modified and not any of the stuff that you didn't
There was a problem hiding this comment.
@Burke-Daniel I took note of all the functions changed through the commits in this PR, and they go as follows:
- configTemp
- configPressure
- getFIFOvalue
- begin
- readcoeffs
- readBlock
- readByte
- writeByte
- readByteBitField
- measureTempOnce
- measurePressureOnce
- disableFIFO
- getFIFOvalue
- getRawResult
- HAL_I2C_Mem_Read on line 36 of I2CInterface.cpp
…r Debug configuration.
….cpp. Also removed #include <Wire.h> from DPS310.cpp.
After peer coding with Daniel in vs code, all builds well and some functions were polished for STM32. Review would still be appreciated!